From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Prarit Bhargava <prarit@redhat.com>,
Kristen Carlson Accardi <kristen@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
Viresh Kumar <viresh.kumar@linaro.org>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH] cpufreq, intel_pstate, set max_sysfs_pct and min_sysfs_pct on governor switch
Date: Wed, 07 Oct 2015 00:43:55 +0200 [thread overview]
Message-ID: <1755198.JNkaHg87IV@vostro.rjw.lan> (raw)
In-Reply-To: <1444168147-17812-1-git-send-email-prarit@redhat.com>
On Tuesday, October 06, 2015 05:49:07 PM Prarit Bhargava wrote:
> Intel CPUs will not enter higher p-states when after switching from the
> performance governor to the powersave governor, until
> /sys/devices/system/cpu/intel_pstate/min_perf_pct is set to a low value.
> This differs from previous behaviour in which a switch to the powersave
> governor would result in a low default value for min_perf_pct.
>
> The behavior of the powersave governor changed after commit a04759924e25
> ("[cpufreq] intel_pstate: honor user space min_perf_pct override on
> resume"). The commit introduced tracking of performance percentage
> changes via sysfs in order to restore userspace changes during
> suspend/resume. The problem occurs because the global values of the newly
> introduced max_sysfs_pct and min_sysfs_pct are not reset on a governor
> change and this causes the new governor to inherit the previous governor's
> settings.
>
> This patch sets max_sysfs_pct to 100 and min_sysfs_pct to 0 on a governor
> change which fixes the problem with governor switching. These changes
> also make the initial calculations for max_perf_pct and min_perf_pct
> slightly simpler.
>
> Before patch:
> [root@intel-skylake-y-01 power]# cpupower frequency-set -g performance
> [root@intel-skylake-y-01 power]# cat /sys/devices/system/cpu/intel_pstate/min_perf_pct
> 100
> [root@intel-skylake-y-01 power]# cat /sys/devices/system/cpu/intel_pstate/max_perf_pct
> 100
> [root@intel-skylake-y-01 power]# cpupower frequency-set -g powersave
> [root@intel-skylake-y-01 power]# cat /sys/devices/system/cpu/intel_pstate/min_perf_pct
> 100
> [root@intel-skylake-y-01 power]# cat /sys/devices/system/cpu/intel_pstate/max_perf_pct
> 100
>
> After patch:
> [root@intel-skylake-y-01 power]# cpupower frequency-set -g performance
> [root@intel-skylake-y-01 power]# cat /sys/devices/system/cpu/intel_pstate/min_perf_pct
> 100
> [root@intel-skylake-y-01 power]# cat /sys/devices/system/cpu/intel_pstate/max_perf_pct
> 100
> [root@intel-skylake-y-01 power]# cpupower frequency-set -g powersave
> [root@intel-skylake-y-01 power]# cat /sys/devices/system/cpu/intel_pstate/min_perf_pct
> 14
> [root@intel-skylake-y-01 power]# cat /sys/devices/system/cpu/intel_pstate/max_perf_pct
> 100
>
> Also note that I have tested suspend/resume (using CONFIG_PM_DEBUG):
> [root@intel-skylake-y-01 power]# echo 50 > /sys/devices/system/cpu/intel_pstate/min_perf_pct
> [root@intel-skylake-y-01 power]# cat /sys/devices/system/cpu/intel_pstate/*_perf_pct
> 100
> 50
> [root@intel-skylake-y-01 power]# echo devices > /sys/power/pm_test
> [root@intel-skylake-y-01 power]# echo platform > /sys/power/disk
> [root@intel-skylake-y-01 power]# echo disk > /sys/power/state
> [root@intel-skylake-y-01 power]# cat /sys/devices/system/cpu/intel_pstate/*_perf_pct
> 100
> 50
>
> Fixes: a04759924e25 ("[cpufreq] intel_pstate: honor user space min_perf_pct override on resume")
> Cc: Kristen Carlson Accardi <kristen@linux.intel.com>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Cc: linux-pm@vger.kernel.org
> Signed-off-by: Prarit Bhargava <prarit@redhat.com>
> ---
> drivers/cpufreq/intel_pstate.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index 3af9dd7..bb24458 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -986,6 +986,9 @@ static int intel_pstate_set_policy(struct cpufreq_policy *policy)
> if (!policy->cpuinfo.max_freq)
> return -ENODEV;
>
> + limits.min_sysfs_pct = 0;
> + limits.max_sysfs_pct = 100;
> +
> if (policy->policy == CPUFREQ_POLICY_PERFORMANCE &&
> policy->max >= policy->cpuinfo.max_freq) {
> limits.min_policy_pct = 100;
> @@ -1004,9 +1007,9 @@ static int intel_pstate_set_policy(struct cpufreq_policy *policy)
> limits.max_policy_pct = clamp_t(int, limits.max_policy_pct, 0 , 100);
>
> /* Normalize user input to [min_policy_pct, max_policy_pct] */
> - limits.min_perf_pct = max(limits.min_policy_pct, limits.min_sysfs_pct);
> + limits.min_perf_pct = limits.min_policy_pct;
> limits.min_perf_pct = min(limits.max_policy_pct, limits.min_perf_pct);
> - limits.max_perf_pct = min(limits.max_policy_pct, limits.max_sysfs_pct);
> + limits.max_perf_pct = limits.max_sysfs_pct;
> limits.max_perf_pct = max(limits.min_policy_pct, limits.max_perf_pct);
>
> /* Make sure min_perf_pct <= max_perf_pct */
>
Makes sense to me.
Kristen?
next prev parent reply other threads:[~2015-10-06 22:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 21:49 Prarit Bhargava
2015-10-06 22:43 ` Rafael J. Wysocki [this message]
2015-10-06 23:06 ` Rafael J. Wysocki
2015-10-07 6:51 ` Doug Smythies
2015-10-07 9:59 ` Prarit Bhargava
2015-10-07 14:04 ` Doug Smythies
2015-10-07 14:10 ` Prarit Bhargava
2015-10-07 15:40 ` Doug Smythies
2015-10-07 15:46 ` Prarit Bhargava
2015-10-07 18:52 ` Doug Smythies
2015-10-07 20:40 ` Prarit Bhargava
2015-10-07 21:31 ` Prarit Bhargava
2015-10-07 22:05 ` Rafael J. Wysocki
2015-10-07 22:26 ` Doug Smythies
2015-10-07 23:17 ` Prarit Bhargava
2015-10-08 0:13 ` Prarit Bhargava
2015-10-07 23:08 ` Prarit Bhargava
2015-10-07 14:34 ` Prarit Bhargava
2015-10-07 11:38 ` Prarit Bhargava
2015-10-07 12:18 ` Prarit Bhargava
2015-10-07 14:50 ` Prarit Bhargava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1755198.JNkaHg87IV@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=kristen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=prarit@redhat.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®