From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932132AbWFOKNv (ORCPT ); Thu, 15 Jun 2006 06:13:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932463AbWFOKNv (ORCPT ); Thu, 15 Jun 2006 06:13:51 -0400 Received: from mail.clusterfs.com ([206.168.112.78]:43914 "EHLO mail.clusterfs.com") by vger.kernel.org with ESMTP id S932132AbWFOKNt (ORCPT ); Thu, 15 Jun 2006 06:13:49 -0400 From: Nikita Danilov MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17553.12734.272321.820052@gargle.gargle.HOWL> Date: Thu, 15 Jun 2006 14:09:02 +0400 To: Jan Engelhardt Cc: Nathan Scott , "Theodore Ts'o" , Linux Kernel Mailing List Subject: Re: [RFC] Slimming down struct inode Newsgroups: gmane.linux.kernel In-Reply-To: References: <20060613143230.A867599@wobbly.melbourne.sgi.com> <448EC51B.6040404@argo.co.il> <20060614084155.C888012@wobbly.melbourne.sgi.com> <17551.58643.704359.815153@gargle.gargle.HOWL> X-Mailer: VM 7.17 under 21.5 (patch 17) "chayote" (+CVS-20040321) XEmacs Lucid Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Jan Engelhardt writes: > > > >Sorry, but why this operation is needed? Generic code (in fs/*.c) > >doesn't use ->i_blksize at all. If XFS wants to provide per-inode > >st_blksize, all it has to do is to store preferred buffer size in its > >file system specific inode (struct xfs_inode), and use something > >different from generic_fillattr() as its ->i_op->getattr() callback > >(xfs_vn_getattr()). > > > By the way, are there any significant userspace applications that use > i_blksize/i_blkbits? > cp(1), db(3) or any other using st_blksize field of struct statbuf to select the size of IO buffer. > > Jan Engelhardt > -- Nikita.