From: Paul Mackerras <paulus@samba.org>
To: linas@austin.ibm.com (Linas Vepstas)
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]: powerpc: pseries: Print PCI slot location code on failure
Date: Fri, 16 Jun 2006 08:42:20 +1000 [thread overview]
Message-ID: <17553.57932.127038.417630@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20060615221527.GD12389@austin.ibm.com>
Linas Vepstas writes:
> Resending an older patch (from 28 April) that seems to have fallen
> through the cracks, its not in mailine, is not in -mm and its not
> controversial (its mostly a printk change). Tested.
I don't like doing printk on things that might be NULL (i.e. the
result of get_property). Even though printk doesn't crash, it would
be nicer for the user to see "location=unknown" or something rather
than "location=<NULL>".
Paul.
next prev parent reply other threads:[~2006-06-15 22:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-15 22:15 Linas Vepstas
2006-06-15 22:42 ` Paul Mackerras [this message]
2006-06-19 19:29 ` Linas Vepstas
2006-06-19 20:07 ` Linas Vepstas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17553.57932.127038.417630@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=linas@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®