From: "Rob Herring (Arm)" <robh@kernel.org>
To: Ben Collins <bcollins@kernel.org>
Cc: "Andy Shevchenko" <andy@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Ben Collins" <bcollins@watter.com>,
"Nuno Sá" <nuno.sa@analog.com>,
linux-iio@vger.kernel.org, "Andrew Hepp" <andrew.hepp@ahepp.dev>,
"Jonathan Cameron" <jic23@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] dt-bindings: iio: mcp9600: Add microchip,mcp9601 and add constraints
Date: Mon, 18 Aug 2025 15:40:06 -0500 [thread overview]
Message-ID: <175554960690.2041403.1071082388209698923.robh@kernel.org> (raw)
In-Reply-To: <20250818183214.380847-3-bcollins@kernel.org>
On Mon, 18 Aug 2025 14:32:10 -0400, Ben Collins wrote:
> From: Ben Collins <bcollins@watter.com>
>
> Add microchip,mcp9601 compatible in addition to the original
> microchip,mcp9600 to designate support between these two chips.
>
> The current dt-binding has open-circuit and short-circuit as interrupt
> names, but these are only supported in mcp9601.
>
> The OC and SC detection requires that mcp9601 VSENSE be wired up, which
> not only enables the OC SC interrupts, but also the OC and SC status
> register bits.
>
> Add a microchip,vsense boolean to show the chip is wired for this
> support.
>
> Add constraints so this feature only applies if the mcp9601 compatible
> is selected.
>
> Signed-off-by: Ben Collins <bcollins@watter.com>
> ---
> .../iio/temperature/microchip,mcp9600.yaml | 60 ++++++++++++++++++-
> 1 file changed, 57 insertions(+), 3 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/temperature/microchip,mcp9600.yaml: properties:interrupt-names:items:enum: ['open-circuit', 'short-circuit', 'alert1', 'alert2', 'alert3', 'alert4', 'open-circuit', 'short-circuit'] has non-unique elements
hint: "enum" must be an array of either integers or strings
from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250818183214.380847-3-bcollins@kernel.org
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-08-18 20:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-18 18:32 [PATCH v5 0/5] iio: mcp9600: Features and improvements Ben Collins
2025-08-18 18:32 ` [PATCH 1/6] dt-bindings: iio: mcp9600: Set default 3 for thermocouple-type Ben Collins
2025-08-19 6:56 ` Krzysztof Kozlowski
2025-08-18 18:32 ` [PATCH 2/6] dt-bindings: iio: mcp9600: Add microchip,mcp9601 and add constraints Ben Collins
2025-08-18 20:40 ` Rob Herring (Arm) [this message]
2025-08-19 6:57 ` Krzysztof Kozlowski
2025-08-18 18:32 ` [PATCH 3/6] iio: mcp9600: White space and fixed width cleanup Ben Collins
2025-08-19 14:55 ` David Lechner
2025-08-19 15:02 ` David Lechner
2025-08-18 18:32 ` [PATCH 4/6] iio: mcp9600: Recognize chip id for mcp9601 Ben Collins
2025-08-19 14:57 ` David Lechner
2025-08-18 18:32 ` [PATCH 5/6] iio: mcp9600: Add support for thermocouple-type Ben Collins
2025-08-19 14:59 ` David Lechner
2025-08-18 18:32 ` [PATCH 6/6] iio: mcp9600: Add support for IIR filter Ben Collins
2025-08-19 14:05 ` David Lechner
2025-08-19 14:11 ` Ben Collins
2025-08-19 14:15 ` David Lechner
2025-08-19 14:32 ` Ben Collins
2025-08-19 14:43 ` David Lechner
2025-08-19 18:40 ` Jonathan Cameron
2025-08-19 6:55 ` [PATCH v5 0/5] iio: mcp9600: Features and improvements Krzysztof Kozlowski
2025-08-19 18:24 ` Jonathan Cameron
2025-08-19 20:44 ` Ben Collins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175554960690.2041403.1071082388209698923.robh@kernel.org \
--to=robh@kernel.org \
--cc=andrew.hepp@ahepp.dev \
--cc=andy@kernel.org \
--cc=bcollins@kernel.org \
--cc=bcollins@watter.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®