From: "Rob Herring (Arm)" <robh@kernel.org>
To: Wei Fang <wei.fang@nxp.com>
Cc: shawnguo@kernel.org, kernel@pengutronix.de,
vadim.fedorenko@linux.dev, linux-kernel@vger.kernel.org,
richardcochran@gmail.com, s.hauer@pengutronix.de,
edumazet@google.com, conor+dt@kernel.org, claudiu.manoil@nxp.com,
vladimir.oltean@nxp.com, davem@davemloft.net, pabeni@redhat.com,
andrew+netdev@lunn.ch, festevam@gmail.com, fushi.peng@nxp.com,
xiaoning.wang@nxp.com, imx@lists.linux.dev, krzk+dt@kernel.org,
Frank.Li@nxp.com, devicetree@vger.kernel.org,
netdev@vger.kernel.org, kuba@kernel.org
Subject: Re: [PATCH v4 net-next 02/15] dt-bindings: net: move ptp-timer property to ethernet-controller.yaml
Date: Tue, 19 Aug 2025 15:43:52 -0500 [thread overview]
Message-ID: <175563623228.1286028.14650660035550911275.robh@kernel.org> (raw)
In-Reply-To: <20250819123620.916637-3-wei.fang@nxp.com>
On Tue, 19 Aug 2025 20:36:07 +0800, Wei Fang wrote:
> For some Ethernet controllers, the PTP timer function is not integrated.
> Instead, the PTP timer is a separate device and provides PTP Hardware
> Clock (PHC) to the Ethernet controller to use, such as NXP FMan MAC,
> ENETC, etc. Therefore, a property is needed to indicate this hardware
> relationship between the Ethernet controller and the PTP timer.
>
> Since this use case is also very common, it is better to add a generic
> property to ethernet-controller.yaml. According to the existing binding
> docs, there are two good candidates, one is the "ptp-timer" defined in
> fsl,fman-dtsec.yaml, and the other is the "ptimer-handle" defined in
> fsl,fman.yaml. From the perspective of the name, the former is more
> straightforward, so move the "ptp-timer" from fsl,fman-dtsec.yaml to
> ethernet-controller.yaml.
>
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
> Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> Reviewed-by: Frank Li <Frank.Li@nxp.com>
>
> ---
> v3 changes:
> New patch, add a generic property instead of adding a property to
> fsl,enetc.yaml
> v4 changes:
> 1. Change the title
> 2. Remove "ptp-timer" from fsl,fman-dtsec.yaml
> ---
> .../devicetree/bindings/net/ethernet-controller.yaml | 5 +++++
> Documentation/devicetree/bindings/net/fsl,fman-dtsec.yaml | 4 ----
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
next prev parent reply other threads:[~2025-08-19 20:43 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-19 12:36 [PATCH v4 net-next 00/15] Add NETC Timer PTP driver and add PTP support for i.MX95 Wei Fang
2025-08-19 12:36 ` [PATCH v4 net-next 01/15] dt-bindings: ptp: add NETC Timer PTP clock Wei Fang
2025-08-19 14:38 ` Frank Li
2025-08-20 1:32 ` Wei Fang
2025-08-19 12:36 ` [PATCH v4 net-next 02/15] dt-bindings: net: move ptp-timer property to ethernet-controller.yaml Wei Fang
2025-08-19 20:43 ` Rob Herring (Arm) [this message]
2025-08-19 12:36 ` [PATCH v4 net-next 03/15] ptp: add helpers to get the phc_index by of_node or dev Wei Fang
2025-08-19 14:45 ` Frank Li
2025-08-19 14:53 ` Jakub Kicinski
2025-08-19 12:36 ` [PATCH v4 net-next 04/15] ptp: netc: add NETC V4 Timer PTP driver support Wei Fang
2025-08-19 15:14 ` Frank Li
2025-08-20 2:48 ` Wei Fang
2025-08-19 15:48 ` Vadim Fedorenko
2025-08-20 1:44 ` Wei Fang
2025-08-19 12:36 ` [PATCH v4 net-next 05/15] ptp: netc: add PTP_CLK_REQ_PPS support Wei Fang
2025-08-19 15:25 ` Frank Li
2025-08-20 2:29 ` Wei Fang
2025-08-19 12:36 ` [PATCH v4 net-next 06/15] ptp: netc: add periodic pulse output support Wei Fang
2025-08-19 15:28 ` Frank Li
2025-08-19 12:36 ` [PATCH v4 net-next 07/15] ptp: netc: add external trigger stamp support Wei Fang
2025-08-19 12:36 ` [PATCH v4 net-next 08/15] ptp: netc: add debugfs support to loop back pulse signal Wei Fang
2025-08-19 12:36 ` [PATCH v4 net-next 09/15] MAINTAINERS: add NETC Timer PTP clock driver section Wei Fang
2025-08-19 12:36 ` [PATCH v4 net-next 10/15] net: enetc: save the parsed information of PTP packet to skb->cb Wei Fang
2025-08-19 12:36 ` [PATCH v4 net-next 11/15] net: enetc: extract enetc_update_ptp_sync_msg() to handle PTP Sync packets Wei Fang
2025-08-19 15:31 ` Frank Li
2025-08-19 12:36 ` [PATCH v4 net-next 12/15] net: enetc: remove unnecessary CONFIG_FSL_ENETC_PTP_CLOCK check Wei Fang
2025-08-19 12:36 ` [PATCH v4 net-next 13/15] net: enetc: add PTP synchronization support for ENETC v4 Wei Fang
2025-08-19 15:34 ` Frank Li
2025-08-20 1:46 ` Wei Fang
2025-08-19 12:36 ` [PATCH v4 net-next 14/15] net: enetc: don't update sync packet checksum if checksum offload is used Wei Fang
2025-08-19 12:36 ` [PATCH v4 15/15] arm64: dts: imx95: add standard PCI device compatible string to NETC Timer Wei Fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175563623228.1286028.14650660035550911275.robh@kernel.org \
--to=robh@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=andrew+netdev@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=festevam@gmail.com \
--cc=fushi.peng@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=vadim.fedorenko@linux.dev \
--cc=vladimir.oltean@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®