From: Sean Christopherson <seanjc@google.com>
To: Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
James Houghton <jthoughton@google.com>
Cc: Venkatesh Srinivas <venkateshs@google.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: selftests: Fix signedness issue with vCPU mmap size check
Date: Tue, 19 Aug 2025 16:12:13 -0700 [thread overview]
Message-ID: <175564466673.3066105.7016376973027336397.b4-ty@google.com> (raw)
In-Reply-To: <20250711001742.1965347-1-jthoughton@google.com>
On Fri, 11 Jul 2025 00:17:42 +0000, James Houghton wrote:
> Check that the return value of KVM_GET_VCPU_MMAP_SIZE is non-negative
> before comparing with sizeof(vcpu_run). If KVM_GET_VCPU_MMAP_SIZE fails,
> it will return -1, and `-1 > sizeof(vcpu_run)` is true, so the ASSERT
> passes.
>
> There are no other locations in tools/testing/selftests/kvm that make
> the same mistake.
>
> [...]
Applied to kvm-x86 selftests, thanks!
[1/1] KVM: selftests: Fix signedness issue with vCPU mmap size check
https://github.com/kvm-x86/linux/commit/a585b8761451
--
https://github.com/kvm-x86/linux/tree/next
prev parent reply other threads:[~2025-08-19 23:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 0:17 James Houghton
2025-07-11 0:29 ` James Houghton
2025-08-19 23:12 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175564466673.3066105.7016376973027336397.b4-ty@google.com \
--to=seanjc@google.com \
--cc=jthoughton@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=venkateshs@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®