From: Vinod Koul <vkoul@kernel.org>
To: Shuai Xue <xueshuai@linux.alibaba.com>,
Colin Ian King <colin.i.king@gmail.com>,
Dan Carpenter <dan.carpenter@linaro.org>
Cc: Vinicius Costa Gomes <vinicius.gomes@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Fenghua Yu <fenghuay@nvidia.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] dmaengine: idxd: Fix double free in idxd_setup_wqs()
Date: Wed, 20 Aug 2025 23:09:14 +0530 [thread overview]
Message-ID: <175571155469.80631.13707540161368362564.b4-ty@kernel.org> (raw)
In-Reply-To: <aJnJW3iYTDDCj9sk@stanley.mountain>
On Mon, 11 Aug 2025 13:43:39 +0300, Dan Carpenter wrote:
> The clean up in idxd_setup_wqs() has had a couple bugs because the error
> handling is a bit subtle. It's simpler to just re-write it in a cleaner
> way. The issues here are:
>
> 1) If "idxd->max_wqs" is <= 0 then we call put_device(conf_dev) when
> "conf_dev" hasn't been initialized.
> 2) If kzalloc_node() fails then again "conf_dev" is invalid. It's
> either uninitialized or it points to the "conf_dev" from the
> previous iteration so it leads to a double free.
>
> [...]
Applied, thanks!
[1/1] dmaengine: idxd: Fix double free in idxd_setup_wqs()
commit: 39aaa337449e71a41d4813be0226a722827ba606
Best regards,
--
~Vinod
prev parent reply other threads:[~2025-08-20 17:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 10:43 Dan Carpenter
2025-08-11 15:43 ` Dave Jiang
2025-08-20 17:39 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175571155469.80631.13707540161368362564.b4-ty@kernel.org \
--to=vkoul@kernel.org \
--cc=colin.i.king@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=fenghuay@nvidia.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vinicius.gomes@intel.com \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®