mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Conor Dooley <conor+dt@kernel.org>,
	Guenter Roeck <groeck@chromium.org>,
	 Tim Harvey <tharvey@gateworks.com>,
	Mathew McBride <matt@traverse.com.au>,
	 Lee Jones <lee@kernel.org>, Benson Leung <bleung@chromium.org>,
	 chrome-platform@lists.linux.dev,
	Michael Walle <mwalle@kernel.org>,
	 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>
Subject: Re: [PATCH] dt-bindings: mfd: Move embedded controllers to own directory
Date: Thu, 21 Aug 2025 08:24:53 -0500	[thread overview]
Message-ID: <175578240828.3438836.9383803134622022528.robh@kernel.org> (raw)
In-Reply-To: <20250821062840.9383-2-krzysztof.kozlowski@linaro.org>


On Thu, 21 Aug 2025 08:28:41 +0200, Krzysztof Kozlowski wrote:
> Move ChromeOS Embedded Controller, Gateworks System Controller and
> Kontron sl28cpld Board Management Controller to new subdirectory
> "embedded-controller" matching their purpose.  MFD is coming from Linux
> and does not really fit the actual purpose of this hardware.
> 
> Rename Gateworks GSC filename to match compatible, as preferred for
> bindings.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> Cc: Mathew McBride <matt@traverse.com.au>
> 
> Lee,
> Can you take it via MFD?
> ---
>  .../bindings/{mfd => embedded-controller}/google,cros-ec.yaml | 2 +-
>  .../gateworks-gsc.yaml => embedded-controller/gw,gsc.yaml}    | 2 +-
>  .../{mfd => embedded-controller}/kontron,sl28cpld.yaml        | 2 +-
>  MAINTAINERS                                                   | 4 ++--
>  4 files changed, 5 insertions(+), 5 deletions(-)
>  rename Documentation/devicetree/bindings/{mfd => embedded-controller}/google,cros-ec.yaml (99%)
>  rename Documentation/devicetree/bindings/{mfd/gateworks-gsc.yaml => embedded-controller/gw,gsc.yaml} (98%)
>  rename Documentation/devicetree/bindings/{mfd => embedded-controller}/kontron,sl28cpld.yaml (97%)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml:
	Error in referenced schema matching $id: http://devicetree.org/schemas/mfd/google,cros-ec.yaml
	Tried these paths (check schema $id if path is wrong):
	/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
	/usr/local/lib/python3.13/dist-packages/dtschema/schemas/mfd/google,cros-ec.yaml

/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/mtk,scp.example.dtb: scp@10500000 (mediatek,mt8192-scp): cros-ec-rpmsg: {'compatible': ['google,cros-ec-rpmsg'], 'mediatek,rpmsg-name': ['cros-ec-rpmsg']} should not be valid under {'description': "Can't find referenced schema: http://devicetree.org/schemas/mfd/google,cros-ec.yaml#"}
	from schema $id: http://devicetree.org/schemas/remoteproc/mtk,scp.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/mtk,scp.example.dtb: scp@10500000 (mediatek,mt8192-scp): cros-ec-rpmsg: Unevaluated properties are not allowed ('compatible', 'mediatek,rpmsg-name' were unexpected)
	from schema $id: http://devicetree.org/schemas/remoteproc/mtk,scp.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/mtk,scp.example.dtb: scp@10500000 (mediatek,mt8195-scp-dual): scp@0:cros-ec-rpmsg: {'compatible': ['google,cros-ec-rpmsg'], 'mediatek,rpmsg-name': ['cros-ec-rpmsg']} should not be valid under {'description': "Can't find referenced schema: http://devicetree.org/schemas/mfd/google,cros-ec.yaml#"}
	from schema $id: http://devicetree.org/schemas/remoteproc/mtk,scp.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/mtk,scp.example.dtb: scp@10500000 (mediatek,mt8195-scp-dual): scp@0:cros-ec-rpmsg: Unevaluated properties are not allowed ('compatible', 'mediatek,rpmsg-name' were unexpected)
	from schema $id: http://devicetree.org/schemas/remoteproc/mtk,scp.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/mtk,scp.example.dtb: scp@10500000 (mediatek,mt8195-scp-dual): scp@a0000:cros-ec-rpmsg: {'compatible': ['google,cros-ec-rpmsg'], 'mediatek,rpmsg-name': ['cros-ec-rpmsg']} should not be valid under {'description': "Can't find referenced schema: http://devicetree.org/schemas/mfd/google,cros-ec.yaml#"}
	from schema $id: http://devicetree.org/schemas/remoteproc/mtk,scp.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/mtk,scp.example.dtb: scp@10500000 (mediatek,mt8195-scp-dual): scp@a0000:cros-ec-rpmsg: Unevaluated properties are not allowed ('compatible', 'mediatek,rpmsg-name' were unexpected)
	from schema $id: http://devicetree.org/schemas/remoteproc/mtk,scp.yaml#

doc reference errors (make refcheckdocs):
Warning: Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml references a file that doesn't exist: Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
Warning: Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml references a file that doesn't exist: Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml: Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml: Documentation/devicetree/bindings/mfd/google,cros-ec.yaml

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250821062840.9383-2-krzysztof.kozlowski@linaro.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


      parent reply	other threads:[~2025-08-21 13:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-21  6:28 Krzysztof Kozlowski
2025-08-21  6:37 ` Michael Walle
2025-08-21  9:57 ` Krzysztof Kozlowski
2025-08-21 13:24 ` Rob Herring (Arm) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175578240828.3438836.9383803134622022528.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=bleung@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=groeck@chromium.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@traverse.com.au \
    --cc=mwalle@kernel.org \
    --cc=tharvey@gateworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®