mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Liam Girdwood <lgirdwood@gmail.com>,
	 Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	 johan+linaro@kernel.org, quic_skakitap@quicinc.com
Subject: Re: [PATCH] regulator: pm8008: fix probe failure due to negative voltage selector
Date: Mon, 25 Aug 2025 21:21:02 +0100	[thread overview]
Message-ID: <175615326276.232492.9513119697865046178.b4-ty@kernel.org> (raw)
In-Reply-To: <20250823-pm8008-negitive-selector-v1-1-52b026a4b5e8@quicinc.com>

On Sat, 23 Aug 2025 01:56:39 +0530, Kamal Wadhwa wrote:
> In the current design, the `pm8008_regulator_get_voltage_sel()` callback
> can return a negative value if the raw voltage value is read as 0 uV from
> the PMIC HW register. This can cause the probe to fail when the
> `machine_constraints_voltage()` check is called during the regulator
> registration flow.
> 
> Fix this by using the helper `regulator_map_voltage_linear_range()` to
> convert the raw value to a voltage selector inside the mentioned get
> voltage selector function. This ensures that the value returned is always
> within the defined range.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: pm8008: fix probe failure due to negative voltage selector
      commit: ef3e9c91ed87f13dba877a20569f4a0accf0612c

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


      reply	other threads:[~2025-08-25 20:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-22 20:26 Kamal Wadhwa
2025-08-25 20:21 ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175615326276.232492.9513119697865046178.b4-ty@kernel.org \
    --to=broonie@kernel.org \
    --cc=johan+linaro@kernel.org \
    --cc=kamal.wadhwa@oss.qualcomm.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_skakitap@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®