From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: "Luke D . Jones" <luke@ljones.dev>, Takashi Iwai <tiwai@suse.de>
Cc: Corentin Chary <corentin.chary@gmail.com>,
Hans de Goede <hansg@kernel.org>,
Jiri Slaby <jirislaby@kernel.org>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: asus-wmi: Fix racy registrations
Date: Thu, 28 Aug 2025 19:20:54 +0300 [thread overview]
Message-ID: <175639805403.20700.2974410587242050974.b4-ty@linux.intel.com> (raw)
In-Reply-To: <20250827052441.23382-1-tiwai@suse.de>
On Wed, 27 Aug 2025 07:24:33 +0200, Takashi Iwai wrote:
> asus_wmi_register_driver() may be called from multiple drivers
> concurrently, which can lead to the racy list operations, eventually
> corrupting the memory and hitting Oops on some ASUS machines.
> Also, the error handling is missing, and it forgot to unregister ACPI
> lps0 dev ops in the error case.
>
> This patch covers those issues by introducing a simple mutex at
> acpi_wmi_register_driver() & *_unregister_driver, and adding the
> proper call of asus_s2idle_check_unregister() in the error path.
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.
The list of commits applied:
[1/1] platform/x86: asus-wmi: Fix racy registrations
commit: 5549202b9c02c2ecbc8634768a3da8d9e82d548d
--
i.
next prev parent reply other threads:[~2025-08-28 16:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-27 5:24 Takashi Iwai
2025-08-28 16:20 ` Ilpo Järvinen [this message]
2025-08-30 1:38 ` Stefan Lippers-Hollmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175639805403.20700.2974410587242050974.b4-ty@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=corentin.chary@gmail.com \
--cc=hansg@kernel.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®