From: Nuno Das Neves <nunodasneves@linux.microsoft.com>
To: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
mhklinux@outlook.com, decui@microsoft.com,
paekkaladevi@linux.microsoft.com,
Nuno Das Neves <nunodasneves@linux.microsoft.com>
Subject: [PATCH 2/6] mshv: Ignore second stats page map result failure
Date: Thu, 28 Aug 2025 17:43:46 -0700 [thread overview]
Message-ID: <1756428230-3599-3-git-send-email-nunodasneves@linux.microsoft.com> (raw)
In-Reply-To: <1756428230-3599-1-git-send-email-nunodasneves@linux.microsoft.com>
From: Purna Pavan Chandra Aekkaladevi <paekkaladevi@linux.microsoft.com>
Some versions of the hypervisor do not support HV_STATUS_AREA_PARENT and
return HV_STATUS_INVALID_PARAMETER for the second stats page mapping
request.
This results a failure in module init. Instead of failing, gracefully
fall back to populating stats_pages[HV_STATS_AREA_PARENT] with the
already-mapped stats_pages[HV_STATS_AREA_SELF].
Signed-off-by: Purna Pavan Chandra Aekkaladevi <paekkaladevi@linux.microsoft.com>
Signed-off-by: Nuno Das Neves <nunodasneves@linux.microsoft.com>
---
drivers/hv/mshv_root_hv_call.c | 43 ++++++++++++++++++++++++++++++----
drivers/hv/mshv_root_main.c | 3 +++
2 files changed, 42 insertions(+), 4 deletions(-)
diff --git a/drivers/hv/mshv_root_hv_call.c b/drivers/hv/mshv_root_hv_call.c
index c9c274f29c3c..1c38576a673c 100644
--- a/drivers/hv/mshv_root_hv_call.c
+++ b/drivers/hv/mshv_root_hv_call.c
@@ -724,6 +724,24 @@ hv_call_notify_port_ring_empty(u32 sint_index)
return hv_result_to_errno(status);
}
+static int
+hv_stats_get_area_type(enum hv_stats_object_type type,
+ const union hv_stats_object_identity *identity)
+{
+ switch (type) {
+ case HV_STATS_OBJECT_HYPERVISOR:
+ return identity->hv.stats_area_type;
+ case HV_STATS_OBJECT_LOGICAL_PROCESSOR:
+ return identity->lp.stats_area_type;
+ case HV_STATS_OBJECT_PARTITION:
+ return identity->partition.stats_area_type;
+ case HV_STATS_OBJECT_VP:
+ return identity->vp.stats_area_type;
+ }
+
+ return -EINVAL;
+}
+
int hv_call_map_stat_page(enum hv_stats_object_type type,
const union hv_stats_object_identity *identity,
void **addr)
@@ -732,7 +750,7 @@ int hv_call_map_stat_page(enum hv_stats_object_type type,
struct hv_input_map_stats_page *input;
struct hv_output_map_stats_page *output;
u64 status, pfn;
- int ret = 0;
+ int hv_status, ret = 0;
do {
local_irq_save(flags);
@@ -747,11 +765,28 @@ int hv_call_map_stat_page(enum hv_stats_object_type type,
pfn = output->map_location;
local_irq_restore(flags);
- if (hv_result(status) != HV_STATUS_INSUFFICIENT_MEMORY) {
- ret = hv_result_to_errno(status);
+
+ hv_status = hv_result(status);
+ if (hv_status != HV_STATUS_INSUFFICIENT_MEMORY) {
if (hv_result_success(status))
break;
- return ret;
+
+ /*
+ * Some versions of the hypervisor do not support the
+ * PARENT stats area. In this case return "success" but
+ * set the page to NULL. The caller checks for this
+ * case instead just uses the SELF area.
+ */
+ if (hv_stats_get_area_type(type, identity) == HV_STATS_AREA_PARENT &&
+ hv_status == HV_STATUS_INVALID_PARAMETER) {
+ pr_debug_once("%s: PARENT area type is unsupported\n",
+ __func__);
+ *addr = NULL;
+ return 0;
+ }
+
+ hv_status_debug(status, "\n");
+ return hv_result_to_errno(status);
}
ret = hv_call_deposit_pages(NUMA_NO_NODE,
diff --git a/drivers/hv/mshv_root_main.c b/drivers/hv/mshv_root_main.c
index bbdefe8a2e9c..56ababab57ce 100644
--- a/drivers/hv/mshv_root_main.c
+++ b/drivers/hv/mshv_root_main.c
@@ -929,6 +929,9 @@ static int mshv_vp_stats_map(u64 partition_id, u32 vp_index,
if (err)
goto unmap_self;
+ if (!stats_pages[HV_STATS_AREA_PARENT])
+ stats_pages[HV_STATS_AREA_PARENT] = stats_pages[HV_STATS_AREA_SELF];
+
return 0;
unmap_self:
--
2.34.1
next prev parent reply other threads:[~2025-08-29 0:43 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 0:43 [PATCH 0/6] mshv: Fixes for stats and vp state page mappings Nuno Das Neves
2025-08-29 0:43 ` [PATCH 1/6] mshv: Only map vp->vp_stats_pages if on root scheduler Nuno Das Neves
2025-09-04 17:00 ` Anirudh Rayabharam
2025-09-05 15:20 ` Praveen K Paladugu
2025-09-05 19:43 ` Easwar Hariharan
2025-09-06 7:11 ` Tianyu Lan
2025-08-29 0:43 ` Nuno Das Neves [this message]
2025-09-05 15:31 ` [PATCH 2/6] mshv: Ignore second stats page map result failure Praveen K Paladugu
2025-09-05 18:48 ` Nuno Das Neves
2025-09-05 19:21 ` Easwar Hariharan
2025-09-08 17:04 ` Nuno Das Neves
2025-09-08 17:22 ` Easwar Hariharan
2025-09-08 18:06 ` Nuno Das Neves
2025-09-09 14:52 ` Praveen K Paladugu
2025-09-09 16:27 ` Easwar Hariharan
2025-09-09 17:31 ` Nuno Das Neves
2025-09-06 17:30 ` Tianyu Lan
2025-08-29 0:43 ` [PATCH 3/6] mshv: Add the HVCALL_GET_PARTITION_PROPERTY_EX hypercall Nuno Das Neves
2025-09-04 17:12 ` Anirudh Rayabharam
2025-09-05 15:40 ` Praveen K Paladugu
2025-09-05 19:28 ` Easwar Hariharan
2025-09-05 23:13 ` Nuno Das Neves
2025-08-29 0:43 ` [PATCH 4/6] mshv: Get the vmm capabilities offered by the hypervisor Nuno Das Neves
2025-09-05 15:43 ` Praveen K Paladugu
2025-09-05 18:49 ` Nuno Das Neves
2025-09-05 19:03 ` Anirudh Rayabharam
2025-09-05 23:07 ` Nuno Das Neves
2025-09-05 19:29 ` Easwar Hariharan
2025-09-06 17:34 ` Tianyu Lan
2025-08-29 0:43 ` [PATCH 5/6] mshv: Allocate vp state page for HVCALL_MAP_VP_STATE_PAGE on L1VH Nuno Das Neves
2025-09-05 16:18 ` Praveen K Paladugu
2025-09-05 19:41 ` Easwar Hariharan
2025-08-29 0:43 ` [PATCH 6/6] mshv: Introduce new hypercall to map stats page for L1VH partitions Nuno Das Neves
2025-09-05 19:50 ` Easwar Hariharan
2025-09-05 23:12 ` Nuno Das Neves
2025-09-08 16:26 ` Easwar Hariharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1756428230-3599-3-git-send-email-nunodasneves@linux.microsoft.com \
--to=nunodasneves@linux.microsoft.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhklinux@outlook.com \
--cc=paekkaladevi@linux.microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®