From: Joe Perches <joe@perches.com>
To: Colin King <colin.king@canonical.com>,
Andrzej Hajda <a.hajda@samsung.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@siol.net>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/bridge: make array frs_limits static, makes object smaller
Date: Thu, 11 Jun 2020 11:01:41 -0700 [thread overview]
Message-ID: <17564b0632ef8ca6a64023fe430d69e861f252f1.camel@perches.com> (raw)
In-Reply-To: <20200611133924.923774-1-colin.king@canonical.com>
On Thu, 2020-06-11 at 14:39 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the array frs_limits on the stack but instead make it
> static. Makes the object code smaller by 123 bytes
>
> Before:
> text data bss dec hex filename
> 23456 5712 64 29232 7230 drivers/gpu/drm/bridge/tc358768.o
>
> After:
> text data bss dec hex filename
> 23333 5712 64 29109 71b5 drivers/gpu/drm/bridge/tc358768.o
>
> (gcc version 9.3.0, amd64)
It's curious that the data size didn't change.
Perhaps you should make sure you do not compile
with allyesconfig when you show these change.
For instance: x86-64 defconfig with this bridge
enabled:
$ size drivers/gpu/drm/bridge/tc358768.o
text data bss dec hex filename
9423 300 0 9723 25fb drivers/gpu/drm/bridge/tc358768.o
prev parent reply other threads:[~2020-06-11 18:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 13:39 Colin King
2020-06-11 18:01 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17564b0632ef8ca6a64023fe430d69e861f252f1.camel@perches.com \
--to=joe@perches.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=colin.king@canonical.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®