mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org,  linux-kernel@vger.kernel.org,
	 Iyappan Subramanian <iyappan@os.amperecomputing.com>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Quan Nguyen <quan@os.amperecomputing.com>,
	 Andrew Lunn <andrew+netdev@lunn.ch>,
	Jakub Kicinski <kuba@kernel.org>,
	 Keyur Chudgar <keyur@os.amperecomputing.com>,
	 "David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org,  Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH net-next 1/2] dt-bindings: net: Convert apm,xgene-enet to DT schema
Date: Mon, 01 Sep 2025 13:34:23 -0500	[thread overview]
Message-ID: <175675161498.5921.10650849049249219942.robh@kernel.org> (raw)
In-Reply-To: <20250829202817.1271907-1-robh@kernel.org>


On Fri, 29 Aug 2025 15:28:14 -0500, Rob Herring (Arm) wrote:
> Convert the APM XGene Ethernet binding to DT schema format.
> 
> Add the missing apm,xgene2-sgenet and apm,xgene2-xgenet compatibles.
> Drop "reg-names" as required. Add support for up to 16 interrupts.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>  .../bindings/net/apm,xgene-enet.yaml          | 114 ++++++++++++++++++
>  .../bindings/net/apm-xgene-enet.txt           |  91 --------------
>  MAINTAINERS                                   |   2 +-
>  3 files changed, 115 insertions(+), 92 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/net/apm,xgene-enet.yaml
>  delete mode 100644 Documentation/devicetree/bindings/net/apm-xgene-enet.txt
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/apm,xgene-enet.example.dtb: ethernet-phy-id001c.c915@3 (ethernet-phy-id001c.c915): $nodename:0: 'ethernet-phy-id001c.c915@3' does not match '^ethernet-phy(@[a-f0-9]+)?$'
	from schema $id: http://devicetree.org/schemas/net/realtek,rtl82xx.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/apm,xgene-enet.example.dtb: ethernet-phy-id001c.c915@3 (ethernet-phy-id001c.c915): Unevaluated properties are not allowed ('reg' was unexpected)
	from schema $id: http://devicetree.org/schemas/net/realtek,rtl82xx.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250829202817.1271907-1-robh@kernel.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


      parent reply	other threads:[~2025-09-01 18:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-29 20:28 Rob Herring (Arm)
2025-08-29 20:28 ` [PATCH net-next 2/2] dt-bindings: net: Convert APM XGene MDIO " Rob Herring (Arm)
2025-08-29 21:10   ` Jacob Keller
2025-08-29 21:10 ` [PATCH net-next 1/2] dt-bindings: net: Convert apm,xgene-enet " Jacob Keller
2025-09-01 18:34 ` Rob Herring (Arm) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175675161498.5921.10650849049249219942.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=iyappan@os.amperecomputing.com \
    --cc=keyur@os.amperecomputing.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=quan@os.amperecomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®