mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	"Javier Carrasco" <javier.carrasco.cruz@gmail.com>,
	"Ramona Alexandra Nechita" <ramona.nechita@analog.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Matti Vaittinen" <matti.vaittinen@fi.rohmeurope.com>,
	"Marcelo Schmitt" <marcelo.schmitt@analog.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-iio@vger.kernel.org,
	"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	linux-kernel@vger.kernel.org, "Hans de Goede" <hansg@kernel.org>,
	"Bartosz Golaszewski" <brgl@bgdev.pl>,
	"Thomas Bonnefille" <thomas.bonnefille@bootlin.com>,
	"Tobias Sperling" <tobias.sperling@softing.com>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Trevor Gamblin" <tgamblin@baylibre.com>,
	devicetree@vger.kernel.org, "Esteban Blanc" <eblanc@baylibre.com>,
	linux-gpio@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: iio: adc: ROHM BD79112 ADC/GPIO
Date: Tue, 02 Sep 2025 12:57:27 -0500	[thread overview]
Message-ID: <175683578289.936608.3477668195039989719.robh@kernel.org> (raw)
In-Reply-To: <77c36ecaf5992ebcabf6ce862bf2a6ec72d9f606.1756813980.git.mazziesaccount@gmail.com>


On Tue, 02 Sep 2025 15:23:54 +0300, Matti Vaittinen wrote:
> The ROHM BD79112 is an ADC/GPIO with 32 channels. The channel inputs can
> be used as ADC or GPIO. Using the GPIOs as IRQ sources isn't supported.
> 
> The ADC is 12-bit, supporting input voltages up to 5.7V, and separate I/O
> voltage supply. Maximum SPI clock rate is 20 MHz (10 MHz with
> daisy-chain configuration) and maximum sampling rate is 1MSPS.
> 
> Add a device tree binding document for the ROHM BD79112.
> 
> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
> ---
>  .../bindings/iio/adc/rohm,bd79112.yaml        | 118 ++++++++++++++++++
>  1 file changed, 118 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/rohm,bd79112.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/rohm,bd79112.example.dtb: adc@0 (rohm,bd79112): '#gpio-cells' is a dependency of 'gpio-controller'
	from schema $id: http://devicetree.org/schemas/gpio/gpio.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/77c36ecaf5992ebcabf6ce862bf2a6ec72d9f606.1756813980.git.mazziesaccount@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2025-09-02 17:57 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-02 12:23 [PATCH 0/3] Support ROHM BD79112 ADC Matti Vaittinen
2025-09-02 12:23 ` [PATCH 1/3] dt-bindings: iio: adc: ROHM BD79112 ADC/GPIO Matti Vaittinen
2025-09-02 17:57   ` Rob Herring (Arm) [this message]
2025-09-02 12:24 ` [PATCH 2/3] iio: adc: Support " Matti Vaittinen
2025-09-02 14:15   ` Andy Shevchenko
2025-09-03  6:52     ` Matti Vaittinen
2025-09-03 11:23       ` Andy Shevchenko
2025-09-03 12:14         ` Matti Vaittinen
2025-09-03 13:29           ` Andy Shevchenko
2025-09-04 12:35             ` Matti Vaittinen
2025-09-04 13:04               ` Andy Shevchenko
2025-09-05  5:47     ` Matti Vaittinen
2025-09-02 15:14   ` David Lechner
2025-09-03  7:03     ` Matti Vaittinen
2025-09-02 22:34   ` Linus Walleij
2025-09-03  5:23     ` Matti Vaittinen
2025-09-03  6:47       ` Linus Walleij
2025-09-03  7:17         ` Matti Vaittinen
2025-09-03  7:17         ` Matti Vaittinen
2025-09-03  8:17           ` Matti Vaittinen
2025-09-03 11:02         ` Nuno Sá
2025-09-03 11:27           ` Andy Shevchenko
2025-09-04 14:02   ` kernel test robot
2025-09-02 12:30 ` [PATCH 3/3] MAINTAINERS: Support ROHM BD79112 ADC Matti Vaittinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175683578289.936608.3477668195039989719.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andy@kernel.org \
    --cc=antoniu.miclaus@analog.com \
    --cc=brgl@bgdev.pl \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=eblanc@baylibre.com \
    --cc=hansg@kernel.org \
    --cc=javier.carrasco.cruz@gmail.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.schmitt@analog.com \
    --cc=matti.vaittinen@fi.rohmeurope.com \
    --cc=mazziesaccount@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=ramona.nechita@analog.com \
    --cc=tgamblin@baylibre.com \
    --cc=thomas.bonnefille@bootlin.com \
    --cc=tobias.sperling@softing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®