From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3836E227BA4 for ; Mon, 8 Sep 2025 11:15:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757330159; cv=none; b=K5/n6u1CGdJuY7etgRqUmHUcWaNHjs7rIFYvTki6CSrdiN65OiOsq5Yov8kJV00fqJE5Nmi6yBtruTqDvj42qWT3RWtfupSkrlzzCVjeWqzC/OHQ8JmKB8rfH4URLKxKCZiVaf6ZjOsjSHrVHA5yYIx30N+ZXPzOQT+R8mwEpTA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757330159; c=relaxed/simple; bh=+8Z8atAnfriG15S5k0i4V2/xNbQzXkz5PziUTXcBQe0=; h=Content-Type:MIME-Version:In-Reply-To:References:Subject:From:Cc: To:Date:Message-ID; b=jShaMPXzsfr8UJwp4ShPktaE+6zEgd6LDIcOPcSmLvpA8Tjr4iNw1LqN2jMTZUQoZZboi2Q3sv35ZFdijyW4wI24olskplmebUcGq/DEDhXoPgZwzAmSCopC/uvPeP74s/HFBGOQRUEmKLmxRHarV9EXJ5NuRwbsDZsU+yVkZ4k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=MtEXD2U+; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="MtEXD2U+" Received: from mail.ideasonboard.com (unknown [IPv6:2401:4900:1c66:c9e9:75f9:f434:33cd:e4fe]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 51346725; Mon, 8 Sep 2025 13:14:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1757330082; bh=+8Z8atAnfriG15S5k0i4V2/xNbQzXkz5PziUTXcBQe0=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=MtEXD2U+aGfOqJspEKZo5QXwh0CeOGPsQ6sDmV/H/A1CAZLTVzuXptUKRuZMD3SnG +TXeXaSYNUpKi8TskBfd15Y0DSIe6wMuGNtFr7LysZfxv249kQCL5TwL2gcBtseZqX DU+BOYzHlhbl2YlEpmH49f6HE4HvR34NDSlv6P64= Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <20250907-vchiq-destage-v2-0-6884505dca78@ideasonboard.com> Subject: Re: [PATCH v2 0/5] staging: Destage VCHIQ interface and MMAL From: Jai Luthra Cc: Florian Fainelli , Broadcom internal kernel review list , Greg Kroah-Hartman , Ray Jui , Scott Branden , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kernel-list@raspberrypi.com, Stefan Wahren , Dave Stevenson , Laurent Pinchart , Umang Jain To: Dan Carpenter Date: Mon, 08 Sep 2025 16:45:46 +0530 Message-ID: <175733014607.8095.7451233410776368088@freya> User-Agent: alot/0.12.dev28+gd2c823fe Hi Dan, Quoting Dan Carpenter (2025-09-08 11:18:25) > It's really hard to review the code when it's just sigle line like > this: >=20 > > .../raspberrypi/vchiq-interface}/vchiq_arm.c | 9 +- >=20 > It's also a head ache to do a cat -n filename and then copy and paste > it into an email message... I thought there was a trick to make the > diff show up in the email? >=20 I am not sure how to configure b4 to give the full file path instead of shortening it after the first file in a list. Does git-format-patch already have some option? I can use that to ease reviews till b4 adds support for this feature. Or did I misunderstand your problem? > regards, > dan carpenter > Thanks, Jai