From: Leon Romanovsky <leon@kernel.org>
To: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
Qianfeng Rong <rongqianfeng@vivo.com>
Subject: Re: [PATCH] RDMA/rdmavt: Use int type to store negative error codes
Date: Tue, 09 Sep 2025 05:49:25 -0400 [thread overview]
Message-ID: <175741136559.672925.13426644093210144698.b4-ty@kernel.org> (raw)
In-Reply-To: <20250826150556.541440-1-rongqianfeng@vivo.com>
On Tue, 26 Aug 2025 23:05:56 +0800, Qianfeng Rong wrote:
> Change 'ret' from u32 to int in alloc_qpn() to store -EINVAL, and remove
> the 'bail' label as it simply returns 'ret'.
>
> Storing negative error codes in an u32 causes no runtime issues, but it's
> ugly as pants, Change 'ret' from u32 to int type - this change has no
> runtime impact.
>
> [...]
Applied, thanks!
[1/1] RDMA/rdmavt: Use int type to store negative error codes
https://git.kernel.org/rdma/rdma/c/6768aee67b1bd6
Best regards,
--
Leon Romanovsky <leon@kernel.org>
prev parent reply other threads:[~2025-09-09 9:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-26 15:05 Qianfeng Rong
2025-09-09 9:49 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175741136559.672925.13426644093210144698.b4-ty@kernel.org \
--to=leon@kernel.org \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=rongqianfeng@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®