From: "Rob Herring (Arm)" <robh@kernel.org>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-input@vger.kernel.org,
Florian Fainelli <florian.fainelli@broadcom.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Conor Dooley <conor+dt@kernel.org>,
linux-amarula@amarulasolutions.com,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>
Subject: Re: [PATCH v2 3/5] dt-bindings: touchscreen: convert raspberrypi,firmware-ts bindings to json schema
Date: Sun, 14 Sep 2025 09:24:27 -0500 [thread overview]
Message-ID: <175785980651.1915009.6987347922143634218.robh@kernel.org> (raw)
In-Reply-To: <20250913092707.1005616-3-dario.binacchi@amarulasolutions.com>
On Sat, 13 Sep 2025 11:26:53 +0200, Dario Binacchi wrote:
> Convert Raspberry Pi firmware 7" touchscreen controller device tree
> binding to json-schema.
>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
>
> ---
>
> Changes in v2:
> - Added in v2
>
> .../touchscreen/raspberrypi,firmware-ts.txt | 26 -----------
> .../touchscreen/raspberrypi,firmware-ts.yaml | 45 +++++++++++++++++++
> 2 files changed, 45 insertions(+), 26 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/raspberrypi,firmware-ts.txt
> create mode 100644 Documentation/devicetree/bindings/input/touchscreen/raspberrypi,firmware-ts.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/input/touchscreen/raspberrypi,firmware-ts.example.dtb: firmware-rpi (raspberrypi,bcm2835-firmware): 'touchscreen' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/arm/bcm/raspberrypi,bcm2835-firmware.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/input/touchscreen/raspberrypi,firmware-ts.example.dtb: firmware-rpi (raspberrypi,bcm2835-firmware): compatible: ['raspberrypi,bcm2835-firmware'] is too short
from schema $id: http://devicetree.org/schemas/arm/bcm/raspberrypi,bcm2835-firmware.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250913092707.1005616-3-dario.binacchi@amarulasolutions.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-09-14 14:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-13 9:26 [PATCH v2 1/5] dt-bindings: touchscreen: convert bu21013 " Dario Binacchi
2025-09-13 9:26 ` [PATCH v2 2/5] dt-bindings: touchscreen: convert eeti " Dario Binacchi
2025-09-13 9:26 ` [PATCH v2 3/5] dt-bindings: touchscreen: convert raspberrypi,firmware-ts " Dario Binacchi
2025-09-14 14:24 ` Rob Herring (Arm) [this message]
2025-09-13 9:26 ` [PATCH v2 4/5] dt-bindings: touchscreen: convert zet6223 " Dario Binacchi
2025-09-13 9:26 ` [PATCH v2 5/5] dt-bindings: touchscreen: remove touchscreen.txt Dario Binacchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175785980651.1915009.6987347922143634218.robh@kernel.org \
--to=robh@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=dario.binacchi@amarulasolutions.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=krzk+dt@kernel.org \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®