mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jai Luthra <jai.luthra@ideasonboard.com>
To: Kieran Bingham <kieran.bingham@ideasonboard.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	Tommaso Merciai <tomm.merciai@gmail.com>
Subject: Re: [PATCH v2 5/8] media: imx335: Handle runtime PM in leaf functions
Date: Mon, 15 Sep 2025 11:58:53 +0530	[thread overview]
Message-ID: <175791773319.7481.4286008141874758651@freya> (raw)
In-Reply-To: <175758928516.1246375.13284167198046981915@ping.linuxembedded.co.uk>

Hi Kieran,

Thanks for the review.

Quoting Kieran Bingham (2025-09-11 16:44:45)
> Quoting Jai Luthra (2025-09-11 09:14:21)
> > Simplify .s_stream callback implementation by moving the runtime PM
> > calls to the leaf functions. This patch should not affect any
> > functionality.
> > 
> > Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
> 
> Looks reasonable to me and although the stop_streaming function changes
> to no longer return a value - it was previously unused so no functional
> change indeed as far as I can see:

Yeah it was unused before. This anyway gets fixed when switching to streams
API in the last patch of the series.

> 
> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> 
> > ---
> >  drivers/media/i2c/imx335.c | 51 ++++++++++++++++++++--------------------------
> >  1 file changed, 22 insertions(+), 29 deletions(-)
> > 

Thanks,
    Jai

  reply	other threads:[~2025-09-15  6:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-11  8:14 [PATCH v2 0/8] media: imx335: Vflip, active state and binning support Jai Luthra
2025-09-11  8:14 ` [PATCH v2 1/8] media: imx335: Rectify name of mode struct Jai Luthra
2025-09-11  8:14 ` [PATCH v2 2/8] media: imx335: Support vertical flip Jai Luthra
2025-09-11  8:14 ` [PATCH v2 3/8] media: imx335: Update the native pixel array width Jai Luthra
2025-09-11  8:14 ` [PATCH v2 4/8] media: imx335: Update HBLANK range on mode change Jai Luthra
2025-09-11  8:14 ` [PATCH v2 5/8] media: imx335: Handle runtime PM in leaf functions Jai Luthra
2025-09-11 11:14   ` Kieran Bingham
2025-09-15  6:28     ` Jai Luthra [this message]
2025-09-11  8:14 ` [PATCH v2 6/8] media: imx355: Use subdev active state Jai Luthra
2025-09-11 14:30   ` Kieran Bingham
2025-09-11  8:14 ` [PATCH v2 7/8] media: imx335: Support 2x2 binning Jai Luthra
2025-09-11 11:51   ` Kieran Bingham
2025-09-11  8:14 ` [PATCH v2 8/8] media: imx335: Switch to {enable,disable}_streams Jai Luthra
2025-09-11 11:46   ` Kieran Bingham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175791773319.7481.4286008141874758651@freya \
    --to=jai.luthra@ideasonboard.com \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=tomm.merciai@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®