From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 419C9175D34 for ; Fri, 30 Aug 2024 10:36:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725014209; cv=none; b=AttmRevHW/9uNGmv3VfFzqO7b1Vgo2cFWJ69RXo784gQMtjqP5gfVEeApn+ocwzuZYivmv9+DN564WIsAtb2Cz+RWaJ4wYMrVkFuXXBlc16Mk1nwc5Z9T9IaT2KgUt40JT9IoYbVTjqG3Pbkhedxt+oBQzCCNt3E8l7js7vBcQc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725014209; c=relaxed/simple; bh=WxQVu7PK5+9hhgxdL7oowIXgwn/tPEZh5jvOVe935gw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VSs6FwdqRs0tH1LinryngYmCiyc2hfweDrGgdsTheHDVp1W6afn1r9tVv+wB5mS+uecNiPy+WG2lLIJi/HkCnxHCgwlYgk6y6Ebd0mMGrLP3QgpREBqWGbluIs9DLIpGLh0cGq+ansdZMFqxLUatB8t3JsxQGaEXdTe1lEhj5Tg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NpkGaLM5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NpkGaLM5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3BED8C4CEC2; Fri, 30 Aug 2024 10:36:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725014208; bh=WxQVu7PK5+9hhgxdL7oowIXgwn/tPEZh5jvOVe935gw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=NpkGaLM54K9yTG9BQKmoU5ioGMQKiQsXL+lPerOI5YWpy2MdULM5KI4pjhaqRtDe0 D8EcN2n5NHgTqSF0xVn+FcVyYj7IB1LU+/uO5E6P7/53+QOUAGidpaGDjSa3BpD9zE MZ98vrhYbJWoFKbVnxQQf9f27526ZilHu+IRLRDItzt/V2fq/QjYqB7fEQfIHxBUtV YoWUmw019xGgaOBWh777DUNqdCGcaSO9pMRTFWm5OoM79b0W58WlvTF1cS21Zk0rJm +u/3Y7FciIUOipJ66UmTrFCTRU8Qw3G+z+O6wWcN6bwJrHG/YMFNA8KyAH4fSvw7sx OGrw7p1Y5hT8w== Message-ID: <1757c33c-a407-4a23-806d-658d9abe051f@kernel.org> Date: Fri, 30 Aug 2024 12:36:43 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -next v2 2/4] soc: ti: knav_dma: Use dev_err_probe() to simplfy code To: Nishanth Menon , Jinjie Ruan Cc: ssantosh@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jic23@kernel.org References: <20240830063228.3519385-1-ruanjinjie@huawei.com> <20240830063228.3519385-3-ruanjinjie@huawei.com> <20240830103155.5vs2hdokw6yysq47@finance> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20240830103155.5vs2hdokw6yysq47@finance> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 30/08/2024 12:31, Nishanth Menon wrote: > On 14:32-20240830, Jinjie Ruan wrote: >> Use the dev_err_probe() helper to simplify error handling >> during probe. >> >> Signed-off-by: Jinjie Ruan >> --- >> v2: >> - Split into 2 patches. >> --- >> drivers/soc/ti/knav_dma.c | 12 ++++-------- >> 1 file changed, 4 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/soc/ti/knav_dma.c b/drivers/soc/ti/knav_dma.c >> index 15e41d3a5e22..eeec422a46f0 100644 >> --- a/drivers/soc/ti/knav_dma.c >> +++ b/drivers/soc/ti/knav_dma.c >> @@ -708,17 +708,13 @@ static int knav_dma_probe(struct platform_device *pdev) >> struct device_node *node = pdev->dev.of_node; >> int ret = 0; >> >> - if (!node) { >> - dev_err(&pdev->dev, "could not find device info\n"); >> - return -EINVAL; >> - } >> + if (!node) >> + return dev_err_probe(&pdev->dev, -EINVAL, "could not find device info\n"); >> >> kdev = devm_kzalloc(dev, >> sizeof(struct knav_dma_pool_device), GFP_KERNEL); >> - if (!kdev) { >> - dev_err(dev, "could not allocate driver mem\n"); >> - return -ENOMEM; >> - } >> + if (!kdev) >> + return dev_err_probe(dev, -ENOMEM, "could not allocate driver mem\n"); > > These make no sense to me :( -> just using dev_err_probe when there is > no chance of -EPROBE_DEFER ? Well, this does not make sense from other point of view - memory allocation errors should have any printks... This patchset - like several others from Jinjie - is some sort of automation without careful consideration and without thinking whether code makes sense. Therefore I suggest to review it thoroughly and do not trust the "innocent" look of such changes. Best regards, Krzysztof