From: Will Deacon <will@kernel.org>
To: Catalin Marinas <catalin.marinas@arm.com>,
Marc Zyngier <maz@kernel.org>, Sam Edwards <cfsworks@gmail.com>
Cc: kernel-team@android.com, Will Deacon <will@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Ard Biesheuvel <ardb@kernel.org>,
Ryan Roberts <ryan.roberts@arm.com>,
Baruch Siach <baruch@tkos.co.il>,
Kevin Brodsky <kevin.brodsky@arm.com>,
Joey Gouly <joey.gouly@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Sam Edwards <CFSworks@gmail.com>
Subject: Re: [PATCH v2 0/3] Type correctness cleanup for ARM64 MMU initialization
Date: Tue, 16 Sep 2025 22:13:48 +0100 [thread overview]
Message-ID: <175805162005.266431.9349963404486851031.b4-ty@kernel.org> (raw)
In-Reply-To: <20250904005209.1494370-1-CFSworks@gmail.com>
On Wed, 03 Sep 2025 17:52:06 -0700, Sam Edwards wrote:
> This is a small series of type correctness and readability improvements for
> ARM64's MMU initialization code. When I first encountered this code, the heavy
> use of u64 to represent both virtual and physical addresses made it difficult
> to understand where the demarcations were. I made most of the changes in this
> series while troubleshooting a different problem (fixed in a separate patch) to
> make that boundary a little clearer. I am submitting it now in the hopes that
> this will improve maintainability and readability for others.
>
> [...]
I must confess, I don't personally see a huge amount of value from these
changes. However, I've probably just got used to things and so if this
would've helped you understand the code when you first came across it
recently then I think it's worth having.
Applied to arm64 (for-next/mm), thanks!
[1/3] arm64: mm: Cast start/end markers to char *, not u64
https://git.kernel.org/arm64/c/030b3ffbdac7
[2/3] arm64: mm: Make map_fdt() return mapped pointer
https://git.kernel.org/arm64/c/c56aa9a67a08
[3/3] arm64: mm: Represent physical memory with phys_addr_t and resource_size_t
https://git.kernel.org/arm64/c/b868fff5b10b
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
prev parent reply other threads:[~2025-09-16 21:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 0:52 Sam Edwards
2025-09-04 0:52 ` [PATCH v2 1/3] arm64: mm: Cast start/end markers to char *, not u64 Sam Edwards
2025-09-04 0:52 ` [PATCH v2 2/3] arm64: mm: Make map_fdt() return mapped pointer Sam Edwards
2025-09-04 0:52 ` [PATCH v2 3/3] arm64: mm: Represent physical memory with phys_addr_t and resource_size_t Sam Edwards
2025-09-16 21:13 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175805162005.266431.9349963404486851031.b4-ty@kernel.org \
--to=will@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=ardb@kernel.org \
--cc=baruch@tkos.co.il \
--cc=catalin.marinas@arm.com \
--cc=cfsworks@gmail.com \
--cc=joey.gouly@arm.com \
--cc=kernel-team@android.com \
--cc=kevin.brodsky@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=ryan.roberts@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®