From: Jens Axboe <axboe@kernel.dk>
To: yi.zhang@redhat.com, tj@kernel.org, josef@toxicpanda.com,
hanguangjiang@lixiang.com, liangjie@lixiang.com,
yukuai3@huawei.com, Yu Kuai <yukuai1@huaweicloud.com>
Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, yi.zhang@huawei.com,
yangerkun@huawei.com, johnny.chenyi@huawei.com
Subject: Re: [PATCH v2] blk-throttle: fix throtl_data leak during disk release
Date: Wed, 17 Sep 2025 07:27:52 -0600 [thread overview]
Message-ID: <175811567232.367585.6804225420415541020.b4-ty@kernel.dk> (raw)
In-Reply-To: <20250917075539.62003-1-yukuai1@huaweicloud.com>
On Wed, 17 Sep 2025 15:55:39 +0800, Yu Kuai wrote:
> Tightening the throttle activation check in blk_throtl_activated() to
> require both q->td presence and policy bit set introduced a memory leak
> during disk release:
>
> blkg_destroy_all() clears the policy bit first during queue deactivation,
> causing subsequent blk_throtl_exit() to skip throtl_data cleanup when
> blk_throtl_activated() fails policy check.
>
> [...]
Applied, thanks!
[1/1] blk-throttle: fix throtl_data leak during disk release
(no commit info)
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2025-09-17 13:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-17 7:55 Yu Kuai
2025-09-17 13:27 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175811567232.367585.6804225420415541020.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=hanguangjiang@lixiang.com \
--cc=johnny.chenyi@huawei.com \
--cc=josef@toxicpanda.com \
--cc=liangjie@lixiang.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yi.zhang@redhat.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®