From: Leon Romanovsky <leon@kernel.org>
To: zyjzyj2000@gmail.com, jgg@ziepe.ca, yanjun.zhu@linux.dev,
Gui-Dong Han <hanguidong02@gmail.com>
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
baijiaju1990@gmail.com, rpearsonhpe@gmail.com,
stable@vger.kernel.org
Subject: Re: [PATCH v2] RDMA/rxe: Fix race in do_task() when draining
Date: Sun, 21 Sep 2025 07:22:51 -0400 [thread overview]
Message-ID: <175845377129.2103277.480564364685157164.b4-ty@kernel.org> (raw)
In-Reply-To: <20250919025212.1682087-1-hanguidong02@gmail.com>
On Fri, 19 Sep 2025 02:52:12 +0000, Gui-Dong Han wrote:
> When do_task() exhausts its iteration budget (!ret), it sets the state
> to TASK_STATE_IDLE to reschedule, without a secondary check on the
> current task->state. This can overwrite the TASK_STATE_DRAINING state
> set by a concurrent call to rxe_cleanup_task() or rxe_disable_task().
>
> While state changes are protected by a spinlock, both rxe_cleanup_task()
> and rxe_disable_task() release the lock while waiting for the task to
> finish draining in the while(!is_done(task)) loop. The race occurs if
> do_task() hits its iteration limit and acquires the lock in this window.
> The cleanup logic may then proceed while the task incorrectly
> reschedules itself, leading to a potential use-after-free.
>
> [...]
Applied, thanks!
[1/1] RDMA/rxe: Fix race in do_task() when draining
https://git.kernel.org/rdma/rdma/c/8ca7eada62fcfa
Best regards,
--
Leon Romanovsky <leon@kernel.org>
next prev parent reply other threads:[~2025-09-21 11:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 2:52 Gui-Dong Han
2025-09-19 3:31 ` Yanjun.Zhu
2025-09-21 11:22 ` Leon Romanovsky [this message]
2025-09-21 11:22 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175845377129.2103277.480564364685157164.b4-ty@kernel.org \
--to=leon@kernel.org \
--cc=baijiaju1990@gmail.com \
--cc=hanguidong02@gmail.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
--cc=stable@vger.kernel.org \
--cc=yanjun.zhu@linux.dev \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®