From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751342AbWGRMaU (ORCPT ); Tue, 18 Jul 2006 08:30:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751341AbWGRMaT (ORCPT ); Tue, 18 Jul 2006 08:30:19 -0400 Received: from mail.cs.umn.edu ([128.101.36.202]:14977 "EHLO mail.cs.umn.edu") by vger.kernel.org with ESMTP id S1751340AbWGRMaR (ORCPT ); Tue, 18 Jul 2006 08:30:17 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17596.53679.608190.420651@hound.rchland.ibm.com> Date: Tue, 18 Jul 2006 07:18:55 -0500 To: Arjan van de Ven Cc: Keir Fraser , Ian Pratt , Jeremy Fitzhardinge , xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org, virtualization@lists.osdl.org, Andrew Morton , netdev@vger.kernel.org, Chris Wright Subject: Re: [RFC PATCH 32/33] Add the Xen virtual network device driver. In-Reply-To: <1153219348.3038.60.camel@laptopd505.fenrus.org> References: <20060718091807.467468000@sous-sol.org> <20060718091958.414414000@sous-sol.org> <1153218477.3038.46.camel@laptopd505.fenrus.org> <278d0ba5a24d74c5b590dd76d234c312@cl.cam.ac.uk> <1153219348.3038.60.camel@laptopd505.fenrus.org> X-Mailer: VM 7.19 under Emacs 21.4.1 From: boutcher@cs.umn.edu (Dave Boutcher) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 18 Jul 2006 12:42:28 +0200, Arjan van de Ven said: > > On Tue, 2006-07-18 at 11:35 +0100, Keir Fraser wrote: >> On 18 Jul 2006, at 11:27, Arjan van de Ven wrote: >> >> > Hmmm maybe it's me, but something bugs me if a NIC driver is going to >> > send IP level ARP packets... that just feels very very wrong and is a >> > blatant layering violation.... shouldn't the ifup/ifconfig scripts just >> > be fixed instead if this is critical behavior? >> >> Maybe we should be faking this out from our hotplug scripts in the >> control VM, although triggering this from user space is probably a bit >> of a pain. Regardless, the function can be removed from the driver if >> it's too distasteful: it's only a performance 'hack' to get network >> traffic more quickly redirected when migrating a VM between physical >> hosts. Things won't break horribly if it's removed. > > > that sounds like a perfect job for a udev-kind of notification to > userspace, eg "hey I migrated", and then udev/hotplug can just do this > sending of arps.. maybe they also want to do other things just after a > migration (which sounds entirely reasonable to me) such as renewing the > dhcp lease, resetting the periodic userspace hardware polling timers in > "hal", network manager etc etc... I think we had this discussion the last time these patches came around. Other virtual environments (VMWare, POWER) have the same issue, and there are probably other scenarios (bonding?) that could use the same function. This doesn't belong in the driver. Dave B