From: Bart Van Assche <bvanassche@acm.org>
To: Chanwoo Lee <cw9316.lee@samsung.com>,
alim.akhtar@samsung.com, avri.altman@wdc.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, stanley.chu@mediatek.com,
quic_cang@quicinc.com, mani@kernel.org,
quic_asutoshd@quicinc.com, powen.kao@mediatek.com,
quic_nguyenb@quicinc.com, yang.lee@linux.alibaba.com,
peter.wang@mediatek.com, athierry@redhat.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: grant.jung@samsung.com, jt77.jang@samsung.com,
dh0421.hwang@samsung.com, sh043.lee@samsung.com
Subject: Re: [PATCH 2/2] ufs:mcq:Remove unused parameters
Date: Mon, 8 Jan 2024 09:32:39 -0800 [thread overview]
Message-ID: <175cf5c2-0bf2-48f4-8f48-a9589b6ad916@acm.org> (raw)
In-Reply-To: <20240105021041.20400-3-cw9316.lee@samsung.com>
On 1/4/24 18:10, Chanwoo Lee wrote:
> From: ChanWoo Lee <cw9316.lee@samsung.com>
>
> The 'hwq' parameter is not used in this function.
> So, remove unused parameters.
>
> Signed-off-by: ChanWoo Lee <cw9316.lee@samsung.com>
> ---
> drivers/ufs/core/ufs-mcq.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c
> index edc752e55878..8db81f1a12d5 100644
> --- a/drivers/ufs/core/ufs-mcq.c
> +++ b/drivers/ufs/core/ufs-mcq.c
> @@ -258,9 +258,7 @@ EXPORT_SYMBOL_GPL(ufshcd_mcq_write_cqis);
> * Current MCQ specification doesn't provide a Task Tag or its equivalent in
> * the Completion Queue Entry. Find the Task Tag using an indirect method.
> */
> -static int ufshcd_mcq_get_tag(struct ufs_hba *hba,
> - struct ufs_hw_queue *hwq,
> - struct cq_entry *cqe)
> +static int ufshcd_mcq_get_tag(struct ufs_hba *hba, struct cq_entry *cqe)
> {
> u64 addr;
>
> @@ -278,7 +276,7 @@ static void ufshcd_mcq_process_cqe(struct ufs_hba *hba,
> struct ufs_hw_queue *hwq)
> {
> struct cq_entry *cqe = ufshcd_mcq_cur_cqe(hwq);
> - int tag = ufshcd_mcq_get_tag(hba, hwq, cqe);
> + int tag = ufshcd_mcq_get_tag(hba, cqe);
>
> if (cqe->command_desc_base_addr) {
> ufshcd_compl_one_cqe(hba, tag, cqe);
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2024-01-08 17:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240105021130epcas1p2b77331ab0fc865cc3763765b0b5ecadf@epcas1p2.samsung.com>
2024-01-05 2:10 ` [PATCH 0/2] ufs:mcq:Code cleanups Chanwoo Lee
[not found] ` <CGME20240105021138epcas1p3fdfa70996ddbd282c1067de02e39dbd4@epcas1p3.samsung.com>
2024-01-05 2:10 ` [PATCH 1/2] ufs:mcq:Use ufshcd_mcq_req_to_hwq() to simplify updating hwq Chanwoo Lee
2024-01-08 17:31 ` Bart Van Assche
[not found] ` <CGME20240105021223epcas1p156208a9a445b5e0b527a9eb2d2589ed3@epcas1p1.samsung.com>
2024-01-05 2:10 ` [PATCH 2/2] ufs:mcq:Remove unused parameters Chanwoo Lee
2024-01-08 17:32 ` Bart Van Assche [this message]
2024-01-24 2:35 ` [PATCH 0/2] ufs:mcq:Code cleanups Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175cf5c2-0bf2-48f4-8f48-a9589b6ad916@acm.org \
--to=bvanassche@acm.org \
--cc=alim.akhtar@samsung.com \
--cc=athierry@redhat.com \
--cc=avri.altman@wdc.com \
--cc=cw9316.lee@samsung.com \
--cc=dh0421.hwang@samsung.com \
--cc=grant.jung@samsung.com \
--cc=jejb@linux.ibm.com \
--cc=jt77.jang@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=peter.wang@mediatek.com \
--cc=powen.kao@mediatek.com \
--cc=quic_asutoshd@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=sh043.lee@samsung.com \
--cc=stanley.chu@mediatek.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®