From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 157342391A1 for ; Thu, 5 Dec 2024 10:50:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733395830; cv=none; b=leheXSjWIWZ0P/bRlyyuo1YmG6KUvBzFIQI5DA6DJt3O8gAcsDKr4p9U7/mqFFCxwtoKMkQJRKoo2KTI6Ez1zin7haesDtSfrnmf+3M4Q3N88J/rySUjiTLttO0amQ5D2EJEI/RgClrQuuMu+QWak7+BPAzD5Us9ao6KFnlUTHc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733395830; c=relaxed/simple; bh=GAoOlPofgMBqWfJujDwo+YFQ72CJ4IjJ0WUUmmHruTA=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=IE4wVGlzCbSObgAdV6cdfXg1Z/iS+LUjXbjFHI6GxjEN9Wdg2s2vhOSFWqs7J/YOm9kaY2IGhUwpgXkNAhV+UrtcQ6UMSBSMl01rQYRyGIycBmd8cxjP/rdSOuLdL0FKJA/+nWdIPkLR4zGAc6gntzZVv+vZ02GNz5I0TK2QQDM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MMoKJ5qX; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MMoKJ5qX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733395828; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ycHOMnBh816FhbuXVET66ivDaiNe7YcgyDVzdCppbeA=; b=MMoKJ5qXjFJQ23Gfj8ZzrU/6mTCBEAi9534GKWBxdpHa9LkmnYbEbscZmCrDW/llfnzU3s QyrBzVP0c4W1iBZrENOWhyNsIYgEQGbULCHQlSd8PXn86G1FES950eSkwOm4UMbAuer5s4 c+Ai2Aju/4upatwouwGmCGhfx5eBUWA= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-379-cgDIirxSN7KzzoulNzp7YA-1; Thu, 05 Dec 2024 05:50:23 -0500 X-MC-Unique: cgDIirxSN7KzzoulNzp7YA-1 X-Mimecast-MFC-AGG-ID: cgDIirxSN7KzzoulNzp7YA Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EE7CC1955F68; Thu, 5 Dec 2024 10:50:20 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.48]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6B9F71956052; Thu, 5 Dec 2024 10:50:16 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <35033e7d707b4c68ae125820230d3cd3@AcuMS.aculab.com> References: <35033e7d707b4c68ae125820230d3cd3@AcuMS.aculab.com> <20241202143057.378147-1-dhowells@redhat.com> <20241202143057.378147-3-dhowells@redhat.com> To: David Laight Cc: dhowells@redhat.com, "netdev@vger.kernel.org" , Marc Dionne , Yunsheng Lin , "David S. Miller" , "Eric Dumazet" , Jakub Kicinski , Paolo Abeni , "linux-afs@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net-next 02/37] rxrpc: Use umin() and umax() rather than min_t()/max_t() where possible Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1760514.1733395814.1@warthog.procyon.org.uk> Date: Thu, 05 Dec 2024 10:50:14 +0000 Message-ID: <1760515.1733395814@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 David Laight wrote: > > Use umin() and umax() rather than min_t()/max_t() where the type specified > > is an unsigned type. > > You are also changing some max() to umax(). Good point. If I have to respin my patches again, I'll update that. > Presumably they have always passed the type check so max() is fine. > And max(foo, 1) would have required that 'foo' be 'signed int' and could > potentially be negative when max(-1, 1) will be 1 but umax(-1, 1) is > undefined. There have been cases like this: unsigned long timeout; ... timeout = max(timeout, 1); where the macro would complain because it thought "timeout" and "1" were different sizes, so "1UL" had to be used. Using umax() deals with that issue. David