From: Chuck Lever <cel@kernel.org>
To: linux-nfs@vger.kernel.org, Jeff Layton <jlayton@kernel.org>,
Eric Biggers <ebiggers@kernel.org>
Cc: Chuck Lever <chuck.lever@oracle.com>, NeilBrown <neil@brown.name>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] nfsd: Use MD5 library instead of crypto_shash
Date: Thu, 16 Oct 2025 14:31:46 -0400 [thread overview]
Message-ID: <176063936413.28537.4413010868699924082.b4-ty@oracle.com> (raw)
In-Reply-To: <20251016181534.17252-1-ebiggers@kernel.org>
From: Chuck Lever <chuck.lever@oracle.com>
On Thu, 16 Oct 2025 11:15:34 -0700, Eric Biggers wrote:
> Update NFSD's support for "legacy client tracking" (which uses MD5) to
> use the MD5 library instead of crypto_shash. This has several benefits:
>
> - Simpler code. Notably, much of the error-handling code is no longer
> needed, since the library functions can't fail.
>
> - Improved performance due to reduced overhead. A microbenchmark of
> nfs4_make_rec_clidname() shows a speedup from 1455 cycles to 425.
>
> [...]
Applied to nfsd-testing, thanks!
Note that the posted version of this patch does not apply cleanly to
the nfsd-testing branch here:
https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git/log/?h=nfsd-testing
Be sure to rebase on that branch when posting subsequence patches
that target NFSD.
[1/1] nfsd: Use MD5 library instead of crypto_shash
commit: 4a8d4b1d4b8abcc0d73b924d4d15828dd2ead301
--
Chuck Lever
next prev parent reply other threads:[~2025-10-16 18:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 18:15 Eric Biggers
2025-10-16 18:20 ` Eric Biggers
2025-10-16 18:31 ` Chuck Lever [this message]
2025-10-16 18:53 ` Eric Biggers
2025-10-16 19:00 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176063936413.28537.4413010868699924082.b4-ty@oracle.com \
--to=cel@kernel.org \
--cc=Dai.Ngo@oracle.com \
--cc=chuck.lever@oracle.com \
--cc=ebiggers@kernel.org \
--cc=jlayton@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®