From: Leon Romanovsky <leon@kernel.org>
To: kalesh-anakkur.purayil@broadcom.com,
YanLong Dai <daiyanlong@kylinos.cn>
Cc: jgg@ziepe.ca, linux-kernel@vger.kernel.org,
linux-rdma@vger.kernel.org, selvin.xavier@broadcom.com,
dyl_wlc@163.com
Subject: Re: [PATCH v2 rdma-rc] RDMA/bnxt_re: Fix a potential memory leak in destroy_gsi_sqp
Date: Sun, 19 Oct 2025 06:48:26 -0400 [thread overview]
Message-ID: <176087090639.147630.2015406926663956214.b4-ty@kernel.org> (raw)
In-Reply-To: <20250924061444.11288-1-daiyanlong@kylinos.cn>
On Wed, 24 Sep 2025 14:14:44 +0800, YanLong Dai wrote:
> The current error handling path in bnxt_re_destroy_gsi_sqp() could lead
> to a resource leak. When bnxt_qplib_destroy_qp() fails, the function
> jumps to the 'fail' label and returns immediately, skipping the call
> to bnxt_qplib_free_qp_res().
>
> Continue the resource teardown even if bnxt_qplib_destroy_qp() fails,
> which aligns with the driver's general error handling strategy and
> prevents the potential leak.
>
> [...]
Applied, thanks!
[1/1] RDMA/bnxt_re: Fix a potential memory leak in destroy_gsi_sqp
https://git.kernel.org/rdma/rdma/c/88de89f184661e
Best regards,
--
Leon Romanovsky <leon@kernel.org>
next prev parent reply other threads:[~2025-10-19 10:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 6:14 YanLong Dai
2025-10-19 10:48 ` Leon Romanovsky [this message]
2025-09-24 6:33 代彦龙
2025-09-26 16:11 åå¤: " yanjun.zhu
2025-09-28 1:11 ` YanLong Dai
2025-09-28 2:06 ` [PATCH " Zhu Yanjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176087090639.147630.2015406926663956214.b4-ty@kernel.org \
--to=leon@kernel.org \
--cc=daiyanlong@kylinos.cn \
--cc=dyl_wlc@163.com \
--cc=jgg@ziepe.ca \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=selvin.xavier@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®