From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A95B1C433EF for ; Mon, 28 Feb 2022 16:39:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237732AbiB1QkF (ORCPT ); Mon, 28 Feb 2022 11:40:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229991AbiB1QkE (ORCPT ); Mon, 28 Feb 2022 11:40:04 -0500 Received: from relay4.hostedemail.com (relay4.hostedemail.com [64.99.140.35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CB015E77A for ; Mon, 28 Feb 2022 08:39:25 -0800 (PST) Received: from omf02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DC0A623715; Mon, 28 Feb 2022 16:39:23 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf02.hostedemail.com (Postfix) with ESMTPA id 5F7028000F; Mon, 28 Feb 2022 16:38:49 +0000 (UTC) Message-ID: <1760d9be590e18b5cccceef6e049651c69556c37.camel@perches.com> Subject: Re: [PATCH v4 2/2] ALSA: core: Remove redundant variable and return the last statement From: Joe Perches To: Takashi Iwai Cc: Meng Tang , perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Date: Mon, 28 Feb 2022 08:39:21 -0800 In-Reply-To: References: <20220228050253.1649-1-tangmeng@uniontech.com> <20220228050253.1649-2-tangmeng@uniontech.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.4-1ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Stat-Signature: dtaitigs3myn5hecefhi3rzmhzwsmi5t X-Rspamd-Server: rspamout03 X-Rspamd-Queue-Id: 5F7028000F X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1/cTFZr/pNsYnF7B693HsSfdXRXrxvc6LM= X-HE-Tag: 1646066329-978216 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2022-02-28 at 17:02 +0100, Takashi Iwai wrote: > On Mon, 28 Feb 2022 06:20:45 +0100, Joe Perches wrote: > > On Mon, 2022-02-28 at 13:02 +0800, Meng Tang wrote: > > > Return the result from file->f_op->open() directly instead of > > > taking this in another redundant variable. Make the typical > > > return the last statement, return early and reduce the indentation > > > too. > > > > > > Signed-off-by: Meng Tang > > > Signed-off-by: Joe Perches > > > > Hi Meng Tang. > > > > For the next time: it's not necessary (or even good) to add a sign-off > > for another person unless they specifically authorize one. > > > > You wrote and are submitting these changes, I merely gave you simple > > suggestions as to how you could improve them. > > Joe, would you like to drop your S-o-b lines from those two patches? > Or shall I keep them? > > thanks, > > Takashi Hi Takashi. Nominally, the sign-off-by chain shows who pushed these changes upstream and I did not and I am not an upstream aggregator. But whatever you choose is OK. It's not really a concern to me. I do think these changes are ok. cheers, Joe