From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90DA1140E47 for ; Mon, 8 Apr 2024 15:23:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712589786; cv=none; b=fgRZaPNLOH6x/nOz83Hs9inHQYSjUdIOlgstYKCzFFllUv8V2vAPH2XkW6aJGsNtazJ+AZUPP2xts1QBNYGdlH1F0CUzZDwTzDSZ4pWgrHXL193AdmzDbSTaEemBULqRNWhJVxE2ih56q0qJ/Q/kjOjoZkpqGjgStzFKQ41rDx0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712589786; c=relaxed/simple; bh=bGKC8/Up8+ganbUnQQMf0gdfJM77eigF0DsnS9gdTWY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kZv9yXvIBuFwuiUNR/YxS5KzFY3feFyNUge+hamUc3EWE1WdVSwgaYxH5TcXtzR1B4e1gNKAmjskHHdwZdWJhr0o6Fue+7CdYXWQDdZIXcREX0QJFRcjp2m8qLprcB83I+AZj2OElPDwd3WMsgCqwWd5glOVURFt++msCsBJmg0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Z+42KfnZ; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Z+42KfnZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712589783; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p1X6fZeFDQkaVHOCXAp3VmowI6Zes/NS81fuOoq72q8=; b=Z+42KfnZYzdAkRKfZWuoy2Qplwvb97Fvf5xWvtJv2MQRpyQ5mCsvjm6FTsvrQLwhMWM4cn pJd+o4Xgc5T5lnaPP+N4hes2DLtu0TvxOMD50T4ZrzXkl/h3hdE0fnz4rzvFP4BuhwzrsQ /X1wQ0MckLexFKShwVr3Zfql5CqaT1o= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-675-2BOmbCw2PPaFUJWfi-E14Q-1; Mon, 08 Apr 2024 11:23:02 -0400 X-MC-Unique: 2BOmbCw2PPaFUJWfi-E14Q-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-515af96a73bso3000414e87.2 for ; Mon, 08 Apr 2024 08:23:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712589781; x=1713194581; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=p1X6fZeFDQkaVHOCXAp3VmowI6Zes/NS81fuOoq72q8=; b=VrZf0hMGwrM8zihN/Nw/l9E5FGzMZGy91E1bkw07s4zufTQKByYAwN510QCJYWZjCy TTMqL109uzWoXu8pmpyIgsUa5jnxmbkpzwPa0RbRBL9vsFtNDbhJydRVkDZ3/td6YQOF Xt0cE13HKCSG8qe1rcd733O8ZEQhgNSxjMMmbgcYm4kRQ5mQundL5KC3smWDWrXfLuSE Xii0wG/IocrmYvdCjilUMBzaDeelU/SEPFMzJefDzpbknelK/TQwWx4ZMizFq6Ju7sVJ rv+Vt/+et9I7xUosvfQ3RePbeKCTXBlt1bQX49gKvE9bSbKc8JvjNjDO6gPf/WHrmioT Wj+w== X-Forwarded-Encrypted: i=1; AJvYcCU71CVNSffDYfUSv3Kdfr+0HbwHoLLA/R/KT2HR+We02v4hkUERprxFU8+3ydwJZKIElz8VbS+ogPoqg7EjNWI2f+gbkrYivg0ecWPK X-Gm-Message-State: AOJu0YyHkoTHA3fm7WxKE9b/3DqLIZYSc2aVHpXnyrmChkrJwZHevwq1 c+0sC/3d37ceas7fO4cp8G7GZ7YjE0ZUe/1gom/iD9R00di19WejU8mE2duENU4Cfq2723tTkxc 23U25OU7jUqqrcEdyMkdDmMA0foOSATcBklMh3d7YWMZAwc1KG8WiOhDMR4EyYQ== X-Received: by 2002:ac2:5999:0:b0:515:bf94:cd38 with SMTP id w25-20020ac25999000000b00515bf94cd38mr5843971lfn.36.1712589780791; Mon, 08 Apr 2024 08:23:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGBRJ8DlMjO/InmEYpooBoBZApWBp5pDYwgdjZIA7BzcXKTSKEHdkJmMnKcAJ5HitTh2OMumQ== X-Received: by 2002:ac2:5999:0:b0:515:bf94:cd38 with SMTP id w25-20020ac25999000000b00515bf94cd38mr5843954lfn.36.1712589780284; Mon, 08 Apr 2024 08:23:00 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id cz26-20020a0564021cba00b0056e3f2f3f7csm3300081edb.12.2024.04.08.08.22.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Apr 2024 08:22:59 -0700 (PDT) Message-ID: <1760f058-de52-4519-8d43-4395a88af4f2@redhat.com> Date: Mon, 8 Apr 2024 17:22:58 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] platform/surface: aggregator_registry: Add support for thermal sensors on the Surface Pro 9 To: Maximilian Luz , Jean Delvare , Guenter Roeck , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= Cc: Ivor Wanders , linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org References: <20240330112409.3402943-1-luzmaximilian@gmail.com> <20240330112409.3402943-4-luzmaximilian@gmail.com> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: <20240330112409.3402943-4-luzmaximilian@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 3/30/24 12:24 PM, Maximilian Luz wrote: > The Surface Pro 9 has thermal sensors connected via the Surface > Aggregator Module. Add a device node to support those. > > Signed-off-by: Maximilian Luz Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note I had to apply this manually do to a conflict with: 3427c443a6dc platform/surface: platform_profile: add fan profile switching which I merged into pdx86/for-next after this series was send out. Please double check I resolved the conflict correct. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/surface/surface_aggregator_registry.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/platform/surface/surface_aggregator_registry.c b/drivers/platform/surface/surface_aggregator_registry.c > index 035d6b4105cd6..c38203c00a705 100644 > --- a/drivers/platform/surface/surface_aggregator_registry.c > +++ b/drivers/platform/surface/surface_aggregator_registry.c > @@ -74,6 +74,12 @@ static const struct software_node ssam_node_tmp_pprof = { > .parent = &ssam_node_root, > }; > > +/* Thermal sensors. */ > +static const struct software_node ssam_node_tmp_sensors = { > + .name = "ssam:01:03:01:00:02", > + .parent = &ssam_node_root, > +}; > + > /* Fan speed function. */ > static const struct software_node ssam_node_fan_speed = { > .name = "ssam:01:05:01:01:01", > @@ -311,6 +317,7 @@ static const struct software_node *ssam_node_group_sp9[] = { > &ssam_node_bat_ac, > &ssam_node_bat_main, > &ssam_node_tmp_pprof, > + &ssam_node_tmp_sensors, > &ssam_node_fan_speed, > &ssam_node_pos_tablet_switch, > &ssam_node_hid_kip_keyboard,