From: "tip-bot2 for David Kaplan" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: David Kaplan <david.kaplan@amd.com>,
"Borislav Petkov (AMD)" <bp@alien8.de>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: x86/urgent] x86/bugs: Qualify RETBLEED_INTEL_MSG
Date: Tue, 21 Oct 2025 10:35:46 -0000 [thread overview]
Message-ID: <176104294615.2601451.15528695828339283083.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20251003171936.155391-1-david.kaplan@amd.com>
The following commit has been merged into the x86/urgent branch of tip:
Commit-ID: 204ced4108f5d38f6804968fd9543cc69c3f8da6
Gitweb: https://git.kernel.org/tip/204ced4108f5d38f6804968fd9543cc69c3f8da6
Author: David Kaplan <david.kaplan@amd.com>
AuthorDate: Fri, 03 Oct 2025 12:19:36 -05:00
Committer: Borislav Petkov (AMD) <bp@alien8.de>
CommitterDate: Tue, 21 Oct 2025 12:32:28 +02:00
x86/bugs: Qualify RETBLEED_INTEL_MSG
When retbleed mitigation is disabled, the kernel already prints an info
message that the system is vulnerable. Recent code restructuring also
inadvertently led to RETBLEED_INTEL_MSG being printed as an error, which is
unnecessary as retbleed mitigation was already explicitly disabled (by config
option, cmdline, etc.).
Qualify this print statement so the warning is not printed unless an actual
retbleed mitigation was selected and is being disabled due to incompatibility
with spectre_v2.
Fixes: e3b78a7ad5ea ("x86/bugs: Restructure retbleed mitigation")
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220624
Signed-off-by: David Kaplan <david.kaplan@amd.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Link: https://patch.msgid.link/20251003171936.155391-1-david.kaplan@amd.com
---
arch/x86/kernel/cpu/bugs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/bugs.c b/arch/x86/kernel/cpu/bugs.c
index 6a526ae..e08de5b 100644
--- a/arch/x86/kernel/cpu/bugs.c
+++ b/arch/x86/kernel/cpu/bugs.c
@@ -1463,7 +1463,9 @@ static void __init retbleed_update_mitigation(void)
break;
default:
if (retbleed_mitigation != RETBLEED_MITIGATION_STUFF) {
- pr_err(RETBLEED_INTEL_MSG);
+ if (retbleed_mitigation != RETBLEED_MITIGATION_NONE)
+ pr_err(RETBLEED_INTEL_MSG);
+
retbleed_mitigation = RETBLEED_MITIGATION_NONE;
}
}
prev parent reply other threads:[~2025-10-21 10:35 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-03 17:19 [PATCH] " David Kaplan
2025-10-06 13:11 ` Borislav Petkov
2025-10-06 13:58 ` Kaplan, David
2025-10-06 14:04 ` Borislav Petkov
2025-10-07 18:22 ` Pawan Gupta
2025-10-07 22:12 ` Borislav Petkov
2025-10-07 23:08 ` Pawan Gupta
2025-10-08 0:14 ` Josh Poimboeuf
2025-10-08 10:21 ` Borislav Petkov
2025-10-09 1:07 ` Josh Poimboeuf
2025-10-09 10:19 ` Borislav Petkov
2025-10-09 6:04 ` Pawan Gupta
2025-10-09 10:15 ` Borislav Petkov
2025-10-09 17:13 ` Pawan Gupta
2025-10-09 18:13 ` Kaplan, David
2025-10-09 23:14 ` Borislav Petkov
2025-10-14 10:50 ` David Laight
2025-11-02 20:11 ` Borislav Petkov
2025-10-09 5:33 ` Pawan Gupta
2025-10-10 1:10 ` Josh Poimboeuf
2025-10-10 18:47 ` Pawan Gupta
2025-10-10 19:19 ` Josh Poimboeuf
2025-10-10 19:24 ` Pawan Gupta
2025-10-10 19:27 ` Kaplan, David
2025-10-10 20:47 ` Josh Poimboeuf
2025-10-10 21:13 ` Kaplan, David
2025-10-11 1:20 ` Josh Poimboeuf
2025-10-21 10:35 ` tip-bot2 for David Kaplan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176104294615.2601451.15528695828339283083.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=bp@alien8.de \
--cc=david.kaplan@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®