From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ian Rogers <irogers@google.com>,
Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org,
James Clark <james.clark@linaro.org>,
Tianyou Li <tianyou.li@intel.com>
Subject: Re: [PATCH] perf annotate: Fix build with NO_SLANG=1
Date: Tue, 21 Oct 2025 17:39:17 -0700 [thread overview]
Message-ID: <176109355722.1850903.12007508719780031483.b4-ty@kernel.org> (raw)
In-Reply-To: <20251021030750.254186-1-namhyung@kernel.org>
On Tue, 21 Oct 2025 12:07:50 +0900, Namhyung Kim wrote:
> The recent change for perf c2c annotate broke build without slang
> support like below.
>
> builtin-annotate.c: In function 'hists__find_annotations':
> builtin-annotate.c:522:73: error: 'NO_ADDR' undeclared (first use in this function); did you mean 'NR_ADDR'?
> 522 | key = hist_entry__tui_annotate(he, evsel, NULL, NO_ADDR);
> | ^~~~~~~
> | NR_ADDR
> builtin-annotate.c:522:73: note: each undeclared identifier is reported only once for each function it appears in
>
> [...]
Applied to perf-tools-next, thanks!
Best regards,
Namhyung
prev parent reply other threads:[~2025-10-22 0:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 3:07 Namhyung Kim
2025-10-21 4:45 ` Li, Tianyou
2025-10-22 0:39 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176109355722.1850903.12007508719780031483.b4-ty@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tianyou.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®