From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Chen-Yu Tsai <wenst@chromium.org>, Lee Jones <lee@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v2 7/7] arm64: dts: mediatek: mt6358: Merge ldo_vcn33_* regulators
Date: Fri, 21 Jul 2023 10:53:45 +0200 [thread overview]
Message-ID: <176141a9-bcf2-d91f-0447-7a2aabd4b602@collabora.com> (raw)
In-Reply-To: <20230721082903.2038975-8-wenst@chromium.org>
Il 21/07/23 10:28, Chen-Yu Tsai ha scritto:
> The ldo_vcn33_bt and ldo_vcn33_wifi regulators are actually the same
> regulator, having the same voltage setting and output pin. There are
> simply two enable bits that are ORed together to enable the regulator.
>
> Having two regulators representing the same output pin is misleading
> from a design matching standpoint, and also error-prone in driver
> implementations.
>
> Now that the bindings have these two merged, merge them in the device
> tree as well. Neither vcn33 regulators are referenced in upstream
> device trees. As far as hardware designs go, none of the Chromebooks
> using MT8183 w/ MT6358 use this output.
>
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
next prev parent reply other threads:[~2023-07-21 8:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 8:28 [PATCH RESEND v2 0/7] regulator: mt6358: Remove bogus regulators and improvements Chen-Yu Tsai
2023-07-21 8:28 ` [PATCH RESEND v2 1/7] mfd: mt6358: Add missing registers for LDO voltage calibration Chen-Yu Tsai
2023-07-21 8:53 ` AngeloGioacchino Del Regno
2023-07-21 8:28 ` [PATCH RESEND v2 2/7] regulator: mt6358: Sync VCN33_* enable status after checking ID Chen-Yu Tsai
2023-07-21 8:53 ` AngeloGioacchino Del Regno
2023-07-21 8:28 ` [PATCH RESEND v2 3/7] regulator: mt6358: Fix incorrect VCN33 sync error message Chen-Yu Tsai
2023-07-21 8:53 ` AngeloGioacchino Del Regno
2023-07-21 8:28 ` [PATCH RESEND v2 4/7] regulator: mt6358: Fail probe on unknown chip ID Chen-Yu Tsai
2023-07-21 8:53 ` AngeloGioacchino Del Regno
2023-07-21 8:28 ` [PATCH RESEND v2 5/7] regulator: mt6358: Add output voltage fine tuning to fixed regulators Chen-Yu Tsai
2023-07-21 8:28 ` [PATCH RESEND v2 6/7] regulator: mt6358: Add output voltage fine tuning to variable LDOs Chen-Yu Tsai
2023-07-21 8:28 ` [PATCH RESEND v2 7/7] arm64: dts: mediatek: mt6358: Merge ldo_vcn33_* regulators Chen-Yu Tsai
2023-07-21 8:53 ` AngeloGioacchino Del Regno [this message]
2023-07-24 12:14 ` (subset) [PATCH RESEND v2 0/7] regulator: mt6358: Remove bogus regulators and improvements Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176141a9-bcf2-d91f-0447-7a2aabd4b602@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®