From: "Rob Herring (Arm)" <robh@kernel.org>
To: Jascha Sundaresan <flizarthanon@gmail.com>
Cc: "Rafał Miłecki" <rafal@milecki.pl>,
devicetree@vger.kernel.org, "Conor Dooley" <conor+dt@kernel.org>,
"Srinivas Kandagatla" <srini@kernel.org>,
linux-kernel@vger.kernel.org,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>
Subject: Re: [PATCH v2] nvmem: layouts: u-boot-env: add optional "env-size" property
Date: Sun, 26 Oct 2025 17:30:00 -0500 [thread overview]
Message-ID: <176151779689.3048651.370574318472729306.robh@kernel.org> (raw)
In-Reply-To: <20251022230740.200742-1-flizarthanon@gmail.com>
On Thu, 23 Oct 2025 03:07:41 +0400, Jascha Sundaresan wrote:
> Some devices reserve a larger NVMEM region for the U-Boot environment
> than the actual environment data length used by U-Boot itself. The CRC32
> in the U-Boot header is calculated over the smaller data length, causing
> CRC validation to fail when Linux reads the full partition.
>
> Allow an optional device tree property "env-size" to specify the
> environment data size to use for CRC computation.
>
> v2: add missing $ref line to DT binding
>
> Signed-off-by: Jascha Sundaresan <flizarthanon@gmail.com>
> ---
> Changes in v2:
> - Added missing "$ref" line to schema for env-size
> - Confirmed dt_binding_check passes
>
> .../devicetree/bindings/nvmem/layouts/u-boot,env.yaml | 7 +++++++
> drivers/nvmem/layouts/u-boot-env.c | 4 +++-
> 2 files changed, 10 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
next prev parent reply other threads:[~2025-10-26 22:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 23:07 Jascha Sundaresan
2025-10-26 22:30 ` Rob Herring (Arm) [this message]
2025-11-07 10:05 ` Jascha Sundaresan
2025-11-10 7:35 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176151779689.3048651.370574318472729306.robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=flizarthanon@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=srini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®