From: "Rob Herring (Arm)" <robh@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Saravana Kannan <saravanak@google.com>,
devicetree@vger.kernel.org,
Dan Carpenter <dan.carpenter@linaro.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
andrea.porta@suse.com
Subject: Re: [PATCH] of: overlay: Avoid spurious error messages in of_overlay_remove()
Date: Mon, 27 Oct 2025 13:48:30 -0500 [thread overview]
Message-ID: <176159090855.1395199.16848791379867357248.robh@kernel.org> (raw)
In-Reply-To: <f756e04e8bc239b33a0428c2dd055f202e214f0b.1761335298.git.christophe.jaillet@wanadoo.fr>
On Fri, 24 Oct 2025 21:50:58 +0200, Christophe JAILLET wrote:
> Make of_overlay_remove() tolerate ovcs_id being 0 without logging an error.
>
> Suggested-by: Dan Carpenter <dan.carpenter@linaro.org>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> This is needed for drivers/misc/rp1/rp1_pci.c where things are taken from
> DT or at runtime. In the former case, ovcs_id is unused and left to 0.
> Being able to tolerate such cases simplify error handling.
>
> This was suggested by Dan as a reply to patch [1].
>
> [1]: https://lore.kernel.org/lkml/4e92a271fdb98560c4e659556a1f3e99e7d0d38e.1760987458.git.christophe.jaillet@wanadoo.fr/
>
> ---
> drivers/of/overlay.c | 3 +++
> 1 file changed, 3 insertions(+)
>
Applied, thanks!
prev parent reply other threads:[~2025-10-27 18:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 19:50 Christophe JAILLET
2025-10-27 18:48 ` Rob Herring (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176159090855.1395199.16848791379867357248.robh@kernel.org \
--to=robh@kernel.org \
--cc=andrea.porta@suse.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dan.carpenter@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®