mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot2 for Thomas Gleixner" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: core/rseq] s390/uaccess: Use unsafe wrappers for ASM GOTO
Date: Wed, 29 Oct 2025 10:24:10 -0000	[thread overview]
Message-ID: <176173345017.2601451.5300987106730295859.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20251027083745.483079889@linutronix.de>

The following commit has been merged into the core/rseq branch of tip:

Commit-ID:     6c5957fa71461c088a95df7772e640ab8b1e3bf3
Gitweb:        https://git.kernel.org/tip/6c5957fa71461c088a95df7772e640ab8b1e3bf3
Author:        Thomas Gleixner <tglx@linutronix.de>
AuthorDate:    Mon, 27 Oct 2025 09:43:52 +01:00
Committer:     Peter Zijlstra <peterz@infradead.org>
CommitterDate: Wed, 29 Oct 2025 11:07:09 +01:00

s390/uaccess: Use unsafe wrappers for ASM GOTO

ASM GOTO is miscompiled by GCC when it is used inside a auto cleanup scope:

bool foo(u32 __user *p, u32 val)
{
	scoped_guard(pagefault)
		unsafe_put_user(val, p, efault);
	return true;
efault:
	return false;
}

It ends up leaking the pagefault disable counter in the fault path. clang
at least fails the build.

S390 is not affected for unsafe_*_user() as it uses its own local label
already, but __get/put_kernel_nofault() lack that.

Rename them to arch_*_kernel_nofault() which makes the generic uaccess
header wrap it with a local label that makes both compilers emit correct
code.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Acked-by: Heiko Carstens <hca@linux.ibm.com>
Link: https://patch.msgid.link/20251027083745.483079889@linutronix.de
---
 arch/s390/include/asm/uaccess.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/s390/include/asm/uaccess.h b/arch/s390/include/asm/uaccess.h
index 3e5b8b6..c5e02ad 100644
--- a/arch/s390/include/asm/uaccess.h
+++ b/arch/s390/include/asm/uaccess.h
@@ -468,8 +468,8 @@ do {									\
 
 #endif /* CONFIG_CC_HAS_ASM_GOTO_OUTPUT && CONFIG_CC_HAS_ASM_AOR_FORMAT_FLAGS */
 
-#define __get_kernel_nofault __mvc_kernel_nofault
-#define __put_kernel_nofault __mvc_kernel_nofault
+#define arch_get_kernel_nofault __mvc_kernel_nofault
+#define arch_put_kernel_nofault __mvc_kernel_nofault
 
 void __cmpxchg_user_key_called_with_bad_pointer(void);
 

  parent reply	other threads:[~2025-10-29 10:24 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-27  8:43 [patch V5 00/12] uaccess: Provide and use scopes for user access Thomas Gleixner
2025-10-27  8:43 ` [patch V5 01/12] ARM: uaccess: Implement missing __get_user_asm_dword() Thomas Gleixner
2025-10-28 13:35   ` Mathieu Desnoyers
2025-10-29 10:24   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:48   ` tip-bot2 for Thomas Gleixner
2025-10-27  8:43 ` [patch V5 02/12] uaccess: Provide ASM GOTO safe wrappers for unsafe_*_user() Thomas Gleixner
2025-10-27 12:12   ` Andrew Cooper
2025-10-28 13:44   ` Mathieu Desnoyers
2025-10-28 14:04   ` Yann Ylavic
2025-10-28 15:53     ` Thomas Gleixner
2025-10-29  9:40       ` [patch V6 " Thomas Gleixner
2025-10-29 10:24         ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:48         ` tip-bot2 for Thomas Gleixner
2025-12-19  8:10         ` [patch V6 02/12] " patchwork-bot+linux-riscv
2025-11-04  6:11   ` [patch V5 " Christophe Leroy
2025-10-27  8:43 ` [patch V5 03/12] x86/uaccess: Use unsafe wrappers for ASM GOTO Thomas Gleixner
2025-10-28 13:50   ` Mathieu Desnoyers
2025-10-29 10:24   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:48   ` tip-bot2 for Thomas Gleixner
2025-10-27  8:43 ` [patch V5 04/12] powerpc/uaccess: " Thomas Gleixner
2025-10-28 13:51   ` Mathieu Desnoyers
2025-10-29 10:24   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:48   ` tip-bot2 for Thomas Gleixner
2025-11-04  6:15   ` [patch V5 04/12] " Christophe Leroy
2025-10-27  8:43 ` [patch V5 05/12] riscv/uaccess: " Thomas Gleixner
2025-10-28 13:52   ` Mathieu Desnoyers
2025-10-29 10:24   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:48   ` tip-bot2 for Thomas Gleixner
2025-10-27  8:43 ` [patch V5 06/12] s390/uaccess: " Thomas Gleixner
2025-10-28 13:54   ` Mathieu Desnoyers
2025-10-29 10:24   ` tip-bot2 for Thomas Gleixner [this message]
2025-11-03 14:48   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-10-27  8:43 ` [patch V5 07/12] uaccess: Provide scoped user access regions Thomas Gleixner
2025-10-28 14:11   ` Mathieu Desnoyers
2025-10-29 10:24   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:48   ` tip-bot2 for Thomas Gleixner
2025-11-04  6:20   ` [patch V5 07/12] " Christophe Leroy
2025-11-04  8:17   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-07 19:17   ` [patch V5 07/12] " David Laight
2025-10-27  8:43 ` [patch V5 08/12] uaccess: Provide put/get_user_inline() Thomas Gleixner
2025-10-28 14:12   ` Mathieu Desnoyers
2025-10-29 10:24   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:48   ` tip-bot2 for Thomas Gleixner
2025-11-04  6:30   ` [patch V5 08/12] " Christophe Leroy
2025-11-04  8:17   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-10-27  8:43 ` [patch V5 09/12] [RFC] coccinelle: misc: Add scoped_masked_$MODE_access() checker script Thomas Gleixner
2025-10-27  8:44 ` [patch V5 10/12] futex: Convert to get/put_user_inline() Thomas Gleixner
2025-10-28 14:24   ` Mathieu Desnoyers
2025-10-28 15:56     ` Thomas Gleixner
2025-10-28 16:02       ` Mathieu Desnoyers
2025-10-28 16:13       ` Linus Torvalds
2025-10-29 10:24   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:48   ` tip-bot2 for Thomas Gleixner
2025-11-04  6:31   ` [patch V5 10/12] " Christophe Leroy
2025-11-04  8:17   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-10-27  8:44 ` [patch V5 11/12] x86/futex: Convert to scoped user access Thomas Gleixner
2025-10-29 10:24   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:48   ` tip-bot2 for Thomas Gleixner
2025-11-04  8:17   ` tip-bot2 for Thomas Gleixner
2025-10-27  8:44 ` [patch V5 12/12] select: " Thomas Gleixner
2025-10-28 14:42   ` Mathieu Desnoyers
2025-10-29 10:24   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:47   ` tip-bot2 for Thomas Gleixner
2025-11-04  6:32   ` [patch V5 12/12] " Christophe Leroy
2025-11-04  8:17   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-10-27 15:53 ` [patch V5 00/12] uaccess: Provide and use scopes for " Linus Torvalds
2025-10-29 10:23 ` Peter Zijlstra
2025-11-03 14:46   ` Peter Zijlstra
2025-11-04  6:35 ` Christophe Leroy
2025-12-19  8:10 ` patchwork-bot+linux-riscv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176173345017.2601451.5300987106730295859.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=hca@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®