From: "Rob Herring (Arm)" <robh@kernel.org>
To: Daniel Golle <daniel@makrotopia.org>
Cc: Peter Christen <peter.christen@siemens.com>,
Hauke Mehrtens <hauke@hauke-m.de>,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Conor Dooley <conor+dt@kernel.org>,
Vladimir Oltean <olteanv@gmail.com>,
devicetree@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Liang Xu <lxu@maxlinear.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
"Livia M. Rosu" <lrosu@maxlinear.com>,
Bing tao Xu <bxu@maxlinear.com>, John Crispin <john@phrozen.org>,
Lukas Stockmann <lukas.stockmann@siemens.com>,
"Benny (Ying-Tsan) Weng" <yweng@maxlinear.com>,
Alexander Sverdlin <alexander.sverdlin@siemens.com>,
netdev@vger.kernel.org, Simon Horman <horms@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Eric Dumazet <edumazet@google.com>, Andrew Lunn <andrew@lunn.ch>,
Juraj Povazanec <jpovazanec@maxlinear.com>,
Avinash Jayaraman <ajayaraman@maxlinear.com>,
Andreas Schirm <andreas.schirm@siemens.com>,
"Fanni (Fang-Yi) Chan" <fchan@maxlinear.com>
Subject: Re: [PATCH net-next v4 10/12] dt-bindings: net: dsa: lantiq,gswip: add support for MaxLinear GSW1xx switches
Date: Wed, 29 Oct 2025 20:19:37 -0500 [thread overview]
Message-ID: <176178717757.3193497.18178330899747787205.robh@kernel.org> (raw)
In-Reply-To: <02272a098447ab0de6d2e9d686469fc6ce355c7d.1761693288.git.daniel@makrotopia.org>
On Wed, 29 Oct 2025 00:18:30 +0000, Daniel Golle wrote:
> Extend the Lantiq GSWIP device tree binding to also cover MaxLinear
> GSW1xx switches which are based on the same hardware IP but connected
> via MDIO instead of being memory-mapped.
>
> Add compatible strings for MaxLinear GSW120, GSW125, GSW140, GSW141,
> and GSW145 switches and adjust the schema to handle the different
> connection methods with conditional properties.
>
> Add MaxLinear GSW125 example showing MDIO-connected configuration.
>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
> v4:
> * drop maxlinear,rx-inverted and maxlinear,tx-inverted properties for
> now in favor of upcoming generic properties
>
> v3:
> * add maxlinear,rx-inverted and maxlinear,tx-inverted properties
>
> v2:
> * remove git conflict left-overs which somehow creeped in
> * indent example with 4 spaces instead of tabs
>
> .../bindings/net/dsa/lantiq,gswip.yaml | 267 +++++++++++++-----
> 1 file changed, 194 insertions(+), 73 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.example.dtb: switch@1f (maxlinear,gsw125): ports:port@4: Unevaluated properties are not allowed ('maxlinear,rx-inverted' was unexpected)
from schema $id: http://devicetree.org/schemas/net/dsa/lantiq,gswip.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/02272a098447ab0de6d2e9d686469fc6ce355c7d.1761693288.git.daniel@makrotopia.org
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-10-30 1:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 0:16 [PATCH net-next v4 00/12] net: dsa: lantiq_gswip: Add support for MaxLinear GSW1xx switch family Daniel Golle
2025-10-29 0:16 ` [PATCH net-next v4 01/12] net: dsa: lantiq_gswip: split into common and MMIO parts Daniel Golle
2025-10-29 0:16 ` [PATCH net-next v4 02/12] net: dsa: lantiq_gswip: support enable/disable learning Daniel Golle
2025-10-29 0:17 ` [PATCH net-next v4 03/12] net: dsa: lantiq_gswip: support Energy Efficient Ethernet Daniel Golle
2025-10-29 0:17 ` [PATCH net-next v4 04/12] net: dsa: lantiq_gswip: set link parameters also for CPU port Daniel Golle
2025-10-29 0:17 ` [PATCH net-next v4 05/12] net: dsa: lantiq_gswip: define and use GSWIP_TABLE_MAC_BRIDGE_VAL1_VALID Daniel Golle
2025-10-29 12:12 ` Daniel Golle
2025-10-29 0:17 ` [PATCH net-next v4 06/12] dt-bindings: net: dsa: lantiq,gswip: add support for MII delay properties Daniel Golle
2025-10-29 0:17 ` [PATCH net-next v4 07/12] net: dsa: lantiq_gswip: allow adjusting MII delays Daniel Golle
2025-10-29 0:17 ` [PATCH net-next v4 08/12] dt-bindings: net: dsa: lantiq,gswip: add MaxLinear RMII refclk output property Daniel Golle
2025-10-29 0:18 ` [PATCH net-next v4 09/12] net: dsa: lantiq_gswip: add vendor property to setup MII refclk output Daniel Golle
2025-10-29 0:18 ` [PATCH net-next v4 10/12] dt-bindings: net: dsa: lantiq,gswip: add support for MaxLinear GSW1xx switches Daniel Golle
2025-10-30 1:19 ` Rob Herring (Arm) [this message]
2025-10-29 0:19 ` [PATCH net-next v4 11/12] net: dsa: add tagging driver for MaxLinear GSW1xx switch family Daniel Golle
2025-10-29 0:20 ` [PATCH net-next v4 12/12] net: dsa: add " Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176178717757.3193497.18178330899747787205.robh@kernel.org \
--to=robh@kernel.org \
--cc=ajayaraman@maxlinear.com \
--cc=alexander.sverdlin@siemens.com \
--cc=andreas.schirm@siemens.com \
--cc=andrew@lunn.ch \
--cc=bxu@maxlinear.com \
--cc=conor+dt@kernel.org \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=fchan@maxlinear.com \
--cc=hauke@hauke-m.de \
--cc=horms@kernel.org \
--cc=john@phrozen.org \
--cc=jpovazanec@maxlinear.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lrosu@maxlinear.com \
--cc=lukas.stockmann@siemens.com \
--cc=lxu@maxlinear.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=peter.christen@siemens.com \
--cc=yweng@maxlinear.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®