From: "Rob Herring (Arm)" <robh@kernel.org>
To: Inochi Amaoto <inochiama@gmail.com>
Cc: Russell King <linux@armlinux.org.uk>,
Conor Dooley <conor.dooley@microchip.com>,
Paolo Abeni <pabeni@redhat.com>,
Conor Dooley <conor+dt@kernel.org>,
linux-stm32@st-md-mailman.stormreply.com,
"David S. Miller" <davem@davemloft.net>,
Longbin Li <looong.bin@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
Han Gao <rabenda.cn@gmail.com>,
devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Icenowy Zheng <uwu@icenowy.me>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Chen Wang <unicorn_wang@outlook.com>,
Eric Dumazet <edumazet@google.com>,
sophgo@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
Vivian Wang <wangruikang@iscas.ac.cn>,
Yixun Lan <dlan@gentoo.org>, Andrew Lunn <andrew+netdev@lunn.ch>,
Jakub Kicinski <kuba@kernel.org>,
linux-kernel@vger.kernel.org,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
netdev@vger.kernel.org, Yao Zi <ziyao@disroot.org>
Subject: Re: [PATCH v5 1/3] dt-bindings: net: sophgo,sg2044-dwmac: add phy mode restriction
Date: Fri, 31 Oct 2025 06:09:47 -0500 [thread overview]
Message-ID: <176190898726.569389.4934903700571310952.robh@kernel.org> (raw)
In-Reply-To: <20251031012428.488184-2-inochiama@gmail.com>
On Fri, 31 Oct 2025 09:24:26 +0800, Inochi Amaoto wrote:
> As the ethernet controller of SG2044 and SG2042 only supports
> RGMII phy. Add phy-mode property to restrict the value.
>
> Also, since SG2042 has internal rx delay in its mac, make
> only "rgmii-txid" and "rgmii-id" valid for phy-mode.
>
> Fixes: e281c48a7336 ("dt-bindings: net: sophgo,sg2044-dwmac: Add support for Sophgo SG2042 dwmac")
> Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> .../bindings/net/sophgo,sg2044-dwmac.yaml | 20 +++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml:93:1: [warning] too many blank lines (2 > 1) (empty-lines)
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20251031012428.488184-2-inochiama@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-10-31 11:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 1:24 [PATCH v5 0/3] net: stmmac: dwmac-sophgo: Add phy interface filter Inochi Amaoto
2025-10-31 1:24 ` [PATCH v5 1/3] dt-bindings: net: sophgo,sg2044-dwmac: add phy mode restriction Inochi Amaoto
2025-10-31 11:09 ` Rob Herring (Arm) [this message]
2025-10-31 1:24 ` [PATCH v5 2/3] net: phy: Add helper for fixing RGMII PHY mode based on internal mac delay Inochi Amaoto
2025-10-31 1:24 ` [PATCH v5 3/3] net: stmmac: dwmac-sophgo: Add phy interface filter Inochi Amaoto
2025-10-31 16:21 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176190898726.569389.4934903700571310952.robh@kernel.org \
--to=robh@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=inochiama@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=looong.bin@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rabenda.cn@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=sophgo@lists.linux.dev \
--cc=unicorn_wang@outlook.com \
--cc=uwu@icenowy.me \
--cc=wangruikang@iscas.ac.cn \
--cc=ziyao@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®