From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932095AbdBPNcd (ORCPT ); Thu, 16 Feb 2017 08:32:33 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:59677 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754749AbdBPNc3 (ORCPT ); Thu, 16 Feb 2017 08:32:29 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Chunyan Zhang , robh+dt@kernel.org, mark.rutland@arm.com, gregkh@linuxfoundation.org, catalin.marinas@arm.com, will.deacon@arm.com, orson.zhai@spreadtrum.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 4/5] sprd_serial: switch comptible string to sc-uart Date: Thu, 16 Feb 2017 14:31:38 +0100 Message-ID: <1761969.45NG6Q1Iyc@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.8.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1487063952-7113-5-git-send-email-chunyan.zhang@spreadtrum.com> References: <1487063952-7113-1-git-send-email-chunyan.zhang@spreadtrum.com> <1487063952-7113-5-git-send-email-chunyan.zhang@spreadtrum.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:/3I9E/LiC4XFQFD4kRRQdy6XX8bBx9q/Y6weR9+Rn46rMMeWNod yZlyS/mcvsrAth3UiL20oqarIj33/PywWyoEgLv+J3gNd6p1eqEiwWiWbja/UN5Arirmitf iFJ2XALmrcVIDa+tYxwCoX2o/0ix+zF9yfvjIapOlPZR4Gv3OpeWG7SZwzP69kkFV2vXbL7 GEiQ1zqU7+f9L5Wa15GrA== X-UI-Out-Filterresults: notjunk:1;V01:K0:6AOQ+FGNwN4=:4JCKWcHp4gcfYPxKpkza0i pElC5H5uCVeyVvuP39jG3wcwC2KvCQpclAaX12aWc/2G6XFH92O5Gx6o2yBVt3Bb1ImTOZeMH mQUmD/KUlxs7BgsCdyt4naQdKKIvKVS8LcTv17B8x2YtaJTSEnSboONES6TeRleB+KGqOShqI wwHDyRSXhLOhqj+/qxXYW74kPXrmN86rLZwwlvrPOs4jHUo66Srcm92zzx8j6XVMaQamaUXK0 Z3QvrLN4ms7KMjvSX7Vf0A6rwxpaz++0H5s1ndU/n7b/UciYlYKA631TVeCaWapL694a5hmHL AgnoicAeYjX2y059qdVdUOd0pgYWBk6N6PtxV0S4ce+IvotuchSQ5By0qwmmJ3ldfwcnZrUeq KG3r8m3LeLmoZnVYclzM4+uiDDVXfpCOLKonFvVajJaTgMWQeLIu13OWNWnqZBLMScuxIr3Et IOu2aBzza+2VLXkayVfVeWEELvE+FnbpC1gyhjrggia+7thE3bvGDDZKW6VHsjw3csiZ03KBJ kiJYFvm5tj1Lt6SGh8j1cCZZ2tIEtKKjLAWXinrvm4SB9vXhEhVklmKrD372HIdVrFWtwJBCS D6dJoO2v1bz0JXRKjPNJmrtoMoJV/t7cOb2qBzseOD7nF7m1WnwHmp8zT2IgkZTx90X+VlofU xmyphJTnT2dze+y1ytPCt3QBLUtF7WgLBhH775XizuAck2MyR17O87b8iEIp1HHX9uTMJmp+6 Unr59rOEoOjK2pD6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, February 14, 2017 5:19:11 PM CET Chunyan Zhang wrote: > static const struct of_device_id serial_ids[] = { > - {.compatible = "sprd,sc9836-uart",}, > + {.compatible = "sprd,sc-uart",}, > {} We really need this to be specific, in case Spreadtrum ever makes a slightly different UART that is not 100% compatible with this one. Also, you can't remove the string you already have, only add to it. Normally when you have a new chip that is compatible with one we already have a driver for, we mark the device as compatible with the old one and avoid having to change the driver, e.g. compatible = "sprd,sc9995-uart", "sprd,sc9836-uart"; This way, the driver could later be changed to handle anything that is compatible with sc9995 differently from sc9836, but by default it would match the original string. Arnd