mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot2 for Thomas Weißschuh" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: thomas.weissschuh@linutronix.de,
	Thomas Gleixner <tglx@linutronix.de>,
	Andreas Larsson <andreas@gaisler.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: timers/vdso] random: vDSO: Remove ifdeffery
Date: Sat, 01 Nov 2025 19:47:55 -0000	[thread overview]
Message-ID: <176202647550.2601451.6445885453710089648.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20251014-vdso-sparc64-generic-2-v4-17-e0607bf49dea@linutronix.de>

The following commit has been merged into the timers/vdso branch of tip:

Commit-ID:     189163e207c49196e52e86737dc3048f37a8eee9
Gitweb:        https://git.kernel.org/tip/189163e207c49196e52e86737dc3048f37a8eee9
Author:        Thomas Weißschuh <thomas.weissschuh@linutronix.de>
AuthorDate:    Tue, 14 Oct 2025 08:49:03 +02:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Sat, 01 Nov 2025 20:44:05 +01:00

random: vDSO: Remove ifdeffery

Ifdeffery in C source files is discouraged.

Use IS_ENABLED() instead.

Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Andreas Larsson <andreas@gaisler.com>
Reviewed-by: Andreas Larsson <andreas@gaisler.com>
Link: https://patch.msgid.link/20251014-vdso-sparc64-generic-2-v4-17-e0607bf49dea@linutronix.de
---
 drivers/char/random.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/drivers/char/random.c b/drivers/char/random.c
index 3860ddd..b0b88c6 100644
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@ -56,9 +56,7 @@
 #include <linux/sched/isolation.h>
 #include <crypto/chacha.h>
 #include <crypto/blake2s.h>
-#ifdef CONFIG_VDSO_GETRANDOM
 #include <vdso/datapage.h>
-#endif
 #include <asm/archrandom.h>
 #include <asm/processor.h>
 #include <asm/irq.h>
@@ -274,7 +272,7 @@ static void crng_reseed(struct work_struct *work)
 	if (next_gen == ULONG_MAX)
 		++next_gen;
 	WRITE_ONCE(base_crng.generation, next_gen);
-#ifdef CONFIG_VDSO_GETRANDOM
+
 	/* base_crng.generation's invalid value is ULONG_MAX, while
 	 * vdso_k_rng_data->generation's invalid value is 0, so add one to the
 	 * former to arrive at the latter. Use smp_store_release so that this
@@ -288,8 +286,9 @@ static void crng_reseed(struct work_struct *work)
 	 * because the vDSO side only checks whether the value changed, without
 	 * actually using or interpreting the value.
 	 */
-	smp_store_release((unsigned long *)&vdso_k_rng_data->generation, next_gen + 1);
-#endif
+	if (IS_ENABLED(CONFIG_VDSO_GETRANDOM))
+		smp_store_release((unsigned long *)&vdso_k_rng_data->generation, next_gen + 1);
+
 	if (!static_branch_likely(&crng_is_ready))
 		crng_init = CRNG_READY;
 	spin_unlock_irqrestore(&base_crng.lock, flags);
@@ -742,9 +741,8 @@ static void __cold _credit_init_bits(size_t bits)
 		if (static_key_initialized && system_unbound_wq)
 			queue_work(system_unbound_wq, &set_ready);
 		atomic_notifier_call_chain(&random_ready_notifier, 0, NULL);
-#ifdef CONFIG_VDSO_GETRANDOM
-		WRITE_ONCE(vdso_k_rng_data->is_ready, true);
-#endif
+		if (IS_ENABLED(CONFIG_VDSO_GETRANDOM))
+			WRITE_ONCE(vdso_k_rng_data->is_ready, true);
 		wake_up_interruptible(&crng_init_wait);
 		kill_fasync(&fasync, SIGIO, POLL_IN);
 		pr_notice("crng init done\n");

  reply	other threads:[~2025-11-01 19:47 UTC|newest]

Thread overview: 92+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-14  6:48 [PATCH v4 00/35] sparc64: vdso: Switch to the generic vDSO library Thomas Weißschuh
2025-10-14  6:48 ` [PATCH v4 01/35] selftests: vDSO: vdso_test_correctness: Handle different tv_usec types Thomas Weißschuh
2025-11-01 19:48   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-10-14  6:48 ` [PATCH v4 02/35] arm64: vDSO: getrandom: Explicitly include asm/alternative.h Thomas Weißschuh
2025-11-01 19:48   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-10-14  6:48 ` [PATCH v4 03/35] arm64: vDSO: gettimeofday: Explicitly include vdso/clocksource.h Thomas Weißschuh
2025-11-01 19:48   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-10-14  6:48 ` [PATCH v4 04/35] arm64: vDSO: compat_gettimeofday: Add explicit includes Thomas Weißschuh
2025-11-01 19:48   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-10-14  6:48 ` [PATCH v4 05/35] ARM: vdso: gettimeofday: " Thomas Weißschuh
2025-11-01 19:48   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-10-14  6:48 ` [PATCH v4 06/35] powerpc/vdso/gettimeofday: Explicitly include vdso/time32.h Thomas Weißschuh
2025-10-14  7:42   ` Christophe Leroy
2025-11-01 19:48   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-10-14  6:48 ` [PATCH v4 07/35] powerpc/vdso: Explicitly include asm/cputable.h and asm/feature-fixups.h Thomas Weißschuh
2025-11-01 19:48   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-10-14  6:48 ` [PATCH v4 08/35] LoongArch: vDSO: Explicitly include asm/vdso/vdso.h Thomas Weißschuh
2025-11-01 19:48   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-10-14  6:48 ` [PATCH v4 09/35] MIPS: vdso: Add include guard to asm/vdso/vdso.h Thomas Weißschuh
2025-11-01 19:48   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-10-14  6:48 ` [PATCH v4 10/35] MIPS: vdso: Explicitly include asm/vdso/vdso.h Thomas Weißschuh
2025-11-01 19:48   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-10-14  6:48 ` [PATCH v4 11/35] random: vDSO: Add explicit includes Thomas Weißschuh
2025-11-01 19:48   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-10-14  6:48 ` [PATCH v4 12/35] vdso/gettimeofday: " Thomas Weißschuh
2025-11-01 19:48   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-10-14  6:48 ` [PATCH v4 13/35] vdso/helpers: Explicitly include vdso/processor.h Thomas Weißschuh
2025-11-01 19:48   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-10-14  6:49 ` [PATCH v4 14/35] vdso/datapage: Remove inclusion of gettimeofday.h Thomas Weißschuh
2025-11-01 19:47   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-10-14  6:49 ` [PATCH v4 15/35] vdso/datapage: Trim down unnecessary includes Thomas Weißschuh
2025-11-01 19:47   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-10-14  6:49 ` [PATCH v4 16/35] random: vDSO: trim vDSO includes Thomas Weißschuh
2025-11-01 19:47   ` [tip: timers/vdso] random: vDSO: Trim " tip-bot2 for Thomas Weißschuh
2025-10-14  6:49 ` [PATCH v4 17/35] random: vDSO: remove ifdeffery Thomas Weißschuh
2025-11-01 19:47   ` tip-bot2 for Thomas Weißschuh [this message]
2025-10-14  6:49 ` [PATCH v4 18/35] random: vDSO: split out datapage update into helper functions Thomas Weißschuh
2025-11-01 19:47   ` [tip: timers/vdso] random: vDSO: Split " tip-bot2 for Thomas Weißschuh
2025-10-14  6:49 ` [PATCH v4 19/35] random: vDSO: only access vDSO datapage after random_init() Thomas Weißschuh
2025-11-01 19:47   ` [tip: timers/vdso] random: vDSO: Only " tip-bot2 for Thomas Weißschuh
2025-10-14  6:49 ` [PATCH v4 20/35] s390/time: Set up vDSO datapage later Thomas Weißschuh
2025-11-01 19:47   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-10-14  6:49 ` [PATCH v4 21/35] vdso/datastore: Reduce scope of some variables in vvar_fault() Thomas Weißschuh
2025-11-01 19:47   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-10-14  6:49 ` [PATCH v4 22/35] vdso/datastore: Drop inclusion of linux/mmap_lock.h Thomas Weißschuh
2025-11-01 19:47   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-10-14  6:49 ` [PATCH v4 23/35] vdso/datastore: Map pages through struct page Thomas Weißschuh
2025-11-01 19:47   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-11-03 15:24   ` [PATCH v4 23/35] " Mark Brown
2025-11-03 15:54     ` Thomas Gleixner
2025-11-03 16:55       ` Mark Brown
     [not found]     ` <CGME20251104084442eucas1p2af1bd88393f4d6a532df1cd41f32a287@eucas1p2.samsung.com>
2025-11-04  8:44       ` Marek Szyprowski
2025-11-04  8:58         ` Thomas Weißschuh
2025-11-04 13:14         ` Mark Brown
2025-11-04 15:43           ` Thomas Weißschuh
2025-11-04 15:47             ` Mark Brown
2025-11-04 16:03               ` Thomas Weißschuh
2025-11-04 16:21                 ` Mark Brown
2025-11-04 13:29         ` Mark Brown
2025-11-06 13:28         ` Mark Brown
2025-11-06 13:32           ` Thomas Weißschuh
2025-11-06 13:39             ` Mark Brown
2025-10-14  6:49 ` [PATCH v4 24/35] vdso/datastore: Allocate data pages dynamically Thomas Weißschuh
2025-11-01 19:47   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-11-04  8:49   ` Lad Prabhakar
2025-11-05 15:34   ` [PATCH v4 24/35] " Heiko Carstens
2025-11-05 16:13     ` Thomas Weißschuh
2025-11-06 12:43     ` Aithal, Srikanth
2025-10-14  6:49 ` [PATCH v4 25/35] sparc64: vdso: Link with -z noexecstack Thomas Weißschuh
2025-11-01 19:47   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-10-14  6:49 ` [PATCH v4 26/35] sparc64: vdso: Remove obsolete "fake section table" reservation Thomas Weißschuh
2025-11-01 19:47   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-10-14  6:49 ` [PATCH v4 27/35] sparc64: vdso: Replace code patching with runtime conditional Thomas Weißschuh
2025-11-01 19:47   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-10-14  6:49 ` [PATCH v4 28/35] sparc64: vdso: Move hardware counter read into header Thomas Weißschuh
2025-11-01 19:47   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-10-14  6:49 ` [PATCH v4 29/35] sparc64: vdso: Move syscall fallbacks " Thomas Weißschuh
2025-11-01 19:47   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-10-14  6:49 ` [PATCH v4 30/35] sparc64: vdso: Introduce vdso/processor.h Thomas Weißschuh
2025-11-01 19:47   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-10-14  6:49 ` [PATCH v4 31/35] sparc64: vdso: Switch to the generic vDSO library Thomas Weißschuh
2025-11-01 19:47   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-10-14  6:49 ` [PATCH v4 32/35] sparc64: vdso2c: Drop sym_vvar_start handling Thomas Weißschuh
2025-11-01 19:47   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-10-14  6:49 ` [PATCH v4 33/35] sparc64: vdso2c: Remove symbol handling Thomas Weißschuh
2025-11-01 19:47   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-10-14  6:49 ` [PATCH v4 34/35] sparc64: vdso: Implement clock_gettime64() Thomas Weißschuh
2025-11-01 19:47   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2025-10-14  6:49 ` [PATCH v4 35/35] clocksource: remove ARCH_CLOCKSOURCE_DATA Thomas Weißschuh
2025-11-01 19:47   ` [tip: timers/vdso] clocksource: Remove ARCH_CLOCKSOURCE_DATA tip-bot2 for Arnd Bergmann
2026-02-27  6:44 [PATCH v2 15/15] random: vDSO: remove ifdeffery Thomas Weißschuh
2026-03-11  9:31 ` [tip: timers/vdso] random: vDSO: Remove ifdeffery tip-bot2 for Thomas Weißschuh
2026-03-11 14:51 ` tip-bot2 for Thomas Weißschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176202647550.2601451.6445885453710089648.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=andreas@gaisler.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=thomas.weissschuh@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®