From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89881305056 for ; Mon, 3 Nov 2025 13:57:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762178274; cv=none; b=GVXYtgu9WDFWjKxkmtf00CrnugwDTxfmDLNFt+/j2YUPskDpAVVzlFEFk8Y5dTy18tb9GsdL3Tcc0GEAuCv5MXgTU4uO6YlGpmHjg8y/L/gJEoqHzkgrwM0dVg4WCIb2svYZKbXCzEZGLUh64qN3qE+smGpt/abQTlGaTtv1NFo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762178274; c=relaxed/simple; bh=VeGaAYfgEvSvT+Gu0xOXuZ+HjyhBKDgEePQmHngeEnA=; h=Content-Type:MIME-Version:In-Reply-To:References:Subject:From:Cc: To:Date:Message-ID; b=V4qJjpPNl6rfBd+B/qOEYVaq93hNBZfcSWGb/w0ZbEtHwpB2i7MEtByAE41siv2OH/QSLwFrjC522m/pG126JtPfYjtZG5Y9KzqTb0DmA7/eJfrPAcTQfaAwg2hfZ3WAMwYFZGrsoZ9aZ7MCFOO9UOjXIqIqQVX00XdJIKq+PD0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=j2ytfEgT; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="j2ytfEgT" Received: from mail.ideasonboard.com (unknown [IPv6:2401:4900:1c69:314e:ee86:ae6e:30:9d13]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 20278C73; Mon, 3 Nov 2025 14:55:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1762178154; bh=VeGaAYfgEvSvT+Gu0xOXuZ+HjyhBKDgEePQmHngeEnA=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=j2ytfEgTTV5gfkQzV5pNcUO4KOeAYQ/HLoaNZL1QOKwj5z3Gg9pMI2JFj7Jj1CuyB uCahs2imDsznJp14QWZrzdZdC10nbJUyWc/cWt+OI+Ms4+VXOWzN+Nb6WrobxK+qWa XNLHLQ1TtaZZzuY4ePt8OqTS2AXQJWhimwdWTntc= Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <20251031-b4-vc-sm-cma-v1-0-0dd5c0ec3f5c@ideasonboard.com> <20251031-b4-vc-sm-cma-v1-13-0dd5c0ec3f5c@ideasonboard.com> Subject: Re: [PATCH 13/13] platform/raspberrypi: vchiq: Register vc-sm-cma as a platform driver From: Jai Luthra Cc: Dave Stevenson , Phil Elwell , Stefan Wahren , Laurent Pinchart , Kieran Bingham , Sumit Semwal , Christian =?utf-8?q?K=C3=B6nig?= , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org To: Florian Fainelli , Krzysztof Kozlowski , Raspberry Pi Kernel Maintenance , bcm-kernel-feedback-list@broadcom.com Date: Mon, 03 Nov 2025 19:27:41 +0530 Message-ID: <176217826196.8690.15955501577381404885@freya> User-Agent: alot/0.12.dev28+gd2c823fe Quoting Krzysztof Kozlowski (2025-11-02 15:03:55) > On 31/10/2025 18:27, Jai Luthra wrote: > > From: Dave Stevenson > >=20 > > Register the vc-sm-cma driver as a platform driver under vchiq. > >=20 > > Signed-off-by: Dave Stevenson > > Signed-off-by: Jai Luthra > > --- > > drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c | 3 +++ > > 1 file changed, 3 insertions(+) > >=20 > > diff --git a/drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c b= /drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c > > index 6a7b96d3dae6275a483ef15dc619c5510454765e..09d33bec46ec45175378fff= 8dd1084d0a8a12dd6 100644 > > --- a/drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c > > +++ b/drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c > > @@ -63,6 +63,7 @@ > > * the interface. > > */ > > static struct vchiq_device *bcm2835_audio; > > +static struct vchiq_device *vcsm_cma; >=20 > Please don't write singletons. How do you handle probe of two devices? This driver instantiates all the devices under the vchiq bus during its probe. The VCHIQ firmware doesn't support device enumeration, hence we have to list out the supported devices here. >=20 > > =20 > > static const struct vchiq_platform_info bcm2835_info =3D { > > .cache_line_size =3D 32, > > @@ -1421,6 +1422,7 @@ static int vchiq_probe(struct platform_device *pd= ev) >=20 >=20 > Best regards, > Krzysztof Thanks, Jai