From: Jens Axboe <axboe@kernel.dk>
To: "Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Cong Zhang" <cong.zhang@oss.qualcomm.com>
Cc: linux-arm-msm@vger.kernel.org, virtualization@lists.linux.dev,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
pavan.kondeti@oss.qualcomm.com
Subject: Re: [PATCH] virtio_blk: NULL out vqs to avoid double free on failed resume
Date: Thu, 06 Nov 2025 16:33:41 -0700 [thread overview]
Message-ID: <176247202182.294230.13399520810544725524.b4-ty@kernel.dk> (raw)
In-Reply-To: <20251021-virtio_double_free-v1-1-4dd0cfd258f1@oss.qualcomm.com>
On Tue, 21 Oct 2025 19:07:56 +0800, Cong Zhang wrote:
> The vblk->vqs releases during freeze. If resume fails before vblk->vqs
> is allocated, later freeze/remove may attempt to free vqs again.
> Set vblk->vqs to NULL after freeing to avoid double free.
>
>
Applied, thanks!
[1/1] virtio_blk: NULL out vqs to avoid double free on failed resume
commit: 0739c2c6a015604a7c01506bea28200a2cc2e08c
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2025-11-06 23:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 11:07 Cong Zhang
2025-10-21 12:57 ` Michael S. Tsirkin
2025-10-22 4:19 ` Jason Wang
2025-10-22 5:45 ` Michael S. Tsirkin
2025-10-22 7:01 ` Michael S. Tsirkin
2025-10-22 8:02 ` Cong Zhang
2025-11-05 8:56 ` Cong Zhang
2025-11-06 4:06 ` Jason Wang
2025-11-06 23:33 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176247202182.294230.13399520810544725524.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=cong.zhang@oss.qualcomm.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pavan.kondeti@oss.qualcomm.com \
--cc=pbonzini@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®