From: "Rob Herring (Arm)" <robh@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Han Gao <rabenda.cn@gmail.com>,
linux-riscv@lists.infradead.org, Paul Walmsley <pjw@kernel.org>,
Saravana Kannan <saravanak@google.com>
Subject: Re: [PATCH] of: Skip devicetree kunit tests when RISCV+ACPI doesn't populate root node
Date: Wed, 12 Nov 2025 13:58:56 -0600 [thread overview]
Message-ID: <176297731621.2151636.2516355929483523874.robh@kernel.org> (raw)
In-Reply-To: <20251023160415.705294-1-linux@roeck-us.net>
On Thu, 23 Oct 2025 09:04:14 -0700, Guenter Roeck wrote:
> Starting with commit 69a8b62a7aa1 ("riscv: acpi: avoid errors caused by
> probing DT devices when ACPI is used"), riscv images no longer populate
> devicetree if ACPI is enabled. This causes unit tests to fail which require
> the root node to be set.
>
> # Subtest: of_dtb
> # module: of_test
> 1..2
> # of_dtb_root_node_found_by_path: EXPECTATION FAILED at drivers/of/of_test.c:21
> Expected np is not null, but is
> # of_dtb_root_node_found_by_path: pass:0 fail:1 skip:0 total:1
> not ok 1 of_dtb_root_node_found_by_path
> # of_dtb_root_node_populates_of_root: EXPECTATION FAILED at drivers/of/of_test.c:31
> Expected of_root is not null, but is
> # of_dtb_root_node_populates_of_root: pass:0 fail:1 skip:0 total:1
> not ok 2 of_dtb_root_node_populates_of_root
>
> Skip those tests for RISCV if the root node is not populated.
>
> Fixes: 69a8b62a7aa1 ("riscv: acpi: avoid errors caused by probing DT devices when ACPI is used")
> Cc: Han Gao <rabenda.cn@gmail.com>
> Cc: Paul Walmsley <pjw@kernel.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/of/of_kunit_helpers.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
I guess the riscv folks don't care about supporting the relevant
features either, so I've applied it. Can kicked down the road again.
next prev parent reply other threads:[~2025-11-12 19:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 16:04 Guenter Roeck
2025-10-23 16:48 ` Paul Walmsley
2025-10-24 1:00 ` Rob Herring
2025-10-24 2:54 ` Paul Walmsley
2025-10-24 12:02 ` Rob Herring
2025-10-24 3:45 ` Guenter Roeck
2025-11-12 19:58 ` Rob Herring (Arm) [this message]
2025-11-14 2:53 ` Paul Walmsley
2025-11-21 1:06 ` Rob Herring
2025-11-26 15:58 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176297731621.2151636.2516355929483523874.robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=pjw@kernel.org \
--cc=rabenda.cn@gmail.com \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®