From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B2B42DF15B for ; Mon, 17 Nov 2025 16:42:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763397755; cv=none; b=ET0TL4Rzld4epVTQDZzx7Fb+C3CpuoOGysCm+XnUxS38ipWjejn9ITvGbYv0DfN1DStRHFFVAYwWTiojJxIgHuGESDXpP/Gz9uqYMiXbz5xIXvP8ArKuluz3LHt2gF1Uk7lN5xS0qXhRjA18RF8mV8/EphdNzmPKyBLxhYuNmeI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763397755; c=relaxed/simple; bh=pMxEm4NUjUGTpHRKv7d5LLStUvt+joOsQt6SvZeQ/aA=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=bL8OkVO/zrEE2y/8rm6wZz8p3ldAc85oq6ZmgFgYuS2wFhTbD1qofTbd+8GphZy/dmfa09py7tYupYwhZHCgdX5yojVv6tTWbj41VMyOH/+ybmdQPAVy1lbd87r+NQcJvLQdgqUalkOCkxAtrb6ls1GR2Knrh89mhQ5R4X+WFOk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=RC6bobC4; arc=none smtp.client-ip=209.85.166.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="RC6bobC4" Received: by mail-io1-f47.google.com with SMTP id ca18e2360f4ac-949031532f9so65446139f.0 for ; Mon, 17 Nov 2025 08:42:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1763397753; x=1764002553; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cPLj/39ZpulhoDTDGoazpNeOK1ByBZpHBDDVSHE4zmc=; b=RC6bobC4+TovrvaGkyyJWnIYG9UfB2Q2nRY2/nVuq2FL1hwFL0YESAY7qDvSH+DKdg Yrpfw25/6XVrDtxSVSqQSLeiU7qSKAf0cZ2mO9ry+HTactxFvCZmb2sbzUBNLvOhsMEg i2mpQHBOqZfkBDBQ9xk6iwAKqQ4VPx8UiEHUwokBOwzHaaNEDXOPSAVWua8rNdu4OR+6 MpV7Y/x9GZ1bM2AjRI/WuPc94cBkTR6xTMaUTtvz5LdIsHUkFnw3jkJVmIk9uzQQC6cZ wPw5bI/pIBkhFo0cTEptoscv3eVRhUl266rQ8JgD+HWQYMSbjFfUPrDJLJ1fXzoDigKo nceQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763397753; x=1764002553; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cPLj/39ZpulhoDTDGoazpNeOK1ByBZpHBDDVSHE4zmc=; b=LcB1zsxFs1ULiW5echcdzCImZauGW5MemLiYW7l9N7GY2T8MEhytGBoD6pxeqHRb8g gMb5L49JMTwduW+aTTusekZ6EhE7yM6RmN8i9NnK2K30SxSwtZa6zOvRxVhSwGcXckxI /JY2B6kCi3YOS+BOWIrRxFhUBp/uItmdx/5pXERwRvsv5Tn+NehR5qQwZqcnp8I5mM0A IehzwSQwG0Nr68m5HlWU4Wmc7sS4j371bki203i2xgcNidjuQyoKGY17vDIM8gbPnIya twQiSOfpXbNL6Y3EKPrmbSmQgb5fbuZHlqmgIA408uCes941bqJ9MOd14vlVieBdjCEw hF0A== X-Forwarded-Encrypted: i=1; AJvYcCUPzuM1SWUzcg/G5c1UGzpVl0q6cCchIlTkrglsQTYBuct9s3QL0f1FykL5K0p2OaBrnyqH0IDACod5Tgw=@vger.kernel.org X-Gm-Message-State: AOJu0Ywqdfixsf8Ztl9ziyLf92kZfg4h4/t2mwOTFsHKus6AZxIPLJ9j Y5Cuw36Reo/j8eetLvpt4Vudpl/2q3BqkF+iwaDNOG27WOOs281cLmoSB6HELomVzNg= X-Gm-Gg: ASbGnctb8BOx64c4K8nTZZF5Iwalp6drhWBY6dqwfAY/WRMzrjtS0z8Ejl2cuedGqJy 74rGawgJHKgwZGcdm0+7vz2ag39vhjjtIGJdsedwJshtSCkZ3cagu35/XwirMkb+1hpec6J1MLk JgwQS2kc6Dt3rKs8BC79+hY9UaXvC/8OZvsTgGqTRlO6mu1+ksTCx3bINTA1TwsoFEw35l0EcS3 gk4vaYpblGOoYjInOY/FQ01L2PJ1unZbjLkoJXmgG3aJaYx3/s6ZgvFmbekffu5g9v1eK02TD3Z VVhYDe0nTgYa3y74YdMw+Iz+NYvt5raf14Lkos5bmxu6S3saSGZ7GzulpjisvFUpkIoWMd04THf Vfb9djymtFr/1kgNUPn19flfrtrWMTgAmR9Rg3K9soU/FIwfvlXTe4OUwvBOO+XA3gZMTgUvqCd UIEg== X-Google-Smtp-Source: AGHT+IExXiO+QkYrKnmU03Fq6LXoF/sRtqr6FyMgEi0OFyE/Cj1hbgnilLpBLKEEKN9vWUKT3aE/kg== X-Received: by 2002:a05:6638:9823:b0:5b7:d710:6632 with SMTP id 8926c6da1cb9f-5b7d7106816mr9931097173.11.1763397753282; Mon, 17 Nov 2025 08:42:33 -0800 (PST) Received: from [127.0.0.1] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-5b7bd26e131sm4924100173.20.2025.11.17.08.42.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Nov 2025 08:42:32 -0800 (PST) From: Jens Axboe To: Tejun Heo , Josef Bacik , Khazhismel Kumykov Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Khazhismel Kumykov In-Reply-To: <20251114235434.2168072-1-khazhy@google.com> References: <20251114235434.2168072-1-khazhy@google.com> Subject: Re: [PATCH v2 0/3] block/blk-throttle: Fix throttle slice time for SSDs Message-Id: <176339775226.116629.17706508995359561190.b4-ty@kernel.dk> Date: Mon, 17 Nov 2025 09:42:32 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3 On Fri, 14 Nov 2025 15:54:31 -0800, Khazhismel Kumykov wrote: > Since commit bf20ab538c81 ("blk-throttle: remove CONFIG_BLK_DEV_THROTTLING_LOW"), > the throttle slice time differs between SSD and non-SSD devices. This > causes test failures with slow throttle speeds on SSD devices. > > The first patch in the series fixes the problem by restoring the throttle > slice time to a fixed value, matching behavior seen prior to above > mentioned revert. The remaining patches clean up unneeeded code after removing > CONFIG_BLK_DEV_THROTTLING_LOW. > > [...] Applied, thanks! [1/3] block/blk-throttle: Fix throttle slice time for SSDs commit: f76581f9f1d29e32e120b0242974ba266e79de58 [2/3] block/blk-throttle: drop unneeded blk_stat_enable_accounting commit: 20d0b359c73d15b25abea04066ef4cdbc6a8738d [3/3] block/blk-throttle: Remove throtl_slice from struct throtl_data commit: 6483faa3938bfbd2c9f8ae090f647635f3bd2877 Best regards, -- Jens Axboe