From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BF22336EE2 for ; Mon, 17 Nov 2025 19:14:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.9.28.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763406854; cv=none; b=Vlc1c0GSepZtqKZGjGwRuMyO17aUCIm6anBL7WiCjaNsbV+NTwDAyTypb2EUG6GbOWN3qqfG5nnCyp6scER4Nzk+FlwLbfQcpxty/zHa/92V2aX8SYYgl0J/tsGVrTXaxNMfK9IRflYJIzUsp28UT2ik6DbGUavc1y1a4TWdvuQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763406854; c=relaxed/simple; bh=hOMKgDIZX3avtLzKNyoQVfmby/IhYdvh8+dXSMxKJXg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=sRSNZYSt0fWyIdx3xeKjyN9LuXh9gI8Y0XCBxb2KE7MJq6o4cti86NRUM5W1bOzfacoxPBKag4RScBMjQOjJ1JL1LX0f/E3HkYCG9KPsoqRZtJp/IEtGpoMtk2xNm3U59iLnCAzqMmGn/f2fmQJIF3DnvYm6qyNCrImzxK5jKFE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu; spf=pass smtp.mailfrom=mit.edu; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b=EfGbkzgY; arc=none smtp.client-ip=18.9.28.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mit.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b="EfGbkzgY" Received: from trampoline.thunk.org (pool-173-48-114-69.bstnma.fios.verizon.net [173.48.114.69]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 5AHJDoZi020575 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 17 Nov 2025 14:13:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1763406834; bh=MBfn8g5r6jdKjirEE2DP7ErZrTYQ36dSRqE9rhdy3Cg=; h=From:Subject:Date:Message-ID:MIME-Version:Content-Type; b=EfGbkzgYft7Xe1B6S5ynaZWwixNnfKRcYSY8XEbDBabibu5lbx5wyyOCfUGGozsF6 yX+1HUWNs3+aq5TeIcdppOwQLDZkyZoUgyRAsKBLvgVLscK6CiInxBTt5QMOoLwfND Y9ssocryE056BP3XV7LRexgvFlH1QGQqJ83Kz4J1pFNQrPNlqYT0bjMMB/cPEl71uF T8NQYsLemkdu/WVoziK486hbh6KmP1zXcojHnvsI/AeuaA4v67+emY+5X6Ng9vLY97 1VSBtgYQbBsIFmlE8fzb/e1mKocJrNJtqOrY+XhWQtVFp58+nZxwLEkkUAOlCXVp/S sgTfFeOmMG/xA== Received: by trampoline.thunk.org (Postfix, from userid 15806) id 385892E00D9; Mon, 17 Nov 2025 14:13:50 -0500 (EST) From: "Theodore Ts'o" To: jack@suse.com, Byungchul Park Cc: "Theodore Ts'o" , kernel_team@skhynix.com, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fs/jbd2: use a weaker annotation in journal handling Date: Mon, 17 Nov 2025 14:13:30 -0500 Message-ID: <176340680642.138575.1743360049600398198.b4-ty@mit.edu> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251024073940.1063-1-byungchul@sk.com> References: <20251024073940.1063-1-byungchul@sk.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Fri, 24 Oct 2025 16:39:40 +0900, Byungchul Park wrote: > jbd2 journal handling code doesn't want jbd2_might_wait_for_commit() > to be placed between start_this_handle() and stop_this_handle(). So it > marks the region with rwsem_acquire_read() and rwsem_release(). > > However, the annotation is too strong for that purpose. We don't have > to use more than try lock annotation for that. > > [...] Applied, thanks! [1/1] fs/jbd2: use a weaker annotation in journal handling commit: 40a71b53d5a6d4ea17e4d54b99b2ac03a7f5e783 Best regards, -- Theodore Ts'o