From: Lee Jones <lee@kernel.org>
To: lee@kernel.org, Heiko Stuebner <heiko@sntech.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/4] Improve error handling for qnap-mcu transfers
Date: Thu, 20 Nov 2025 10:15:05 +0000 [thread overview]
Message-ID: <176363370523.591986.4093894713182191137.b4-ty@kernel.org> (raw)
In-Reply-To: <20251105234704.159381-1-heiko@sntech.de>
On Thu, 06 Nov 2025 00:47:00 +0100, Heiko Stuebner wrote:
> Digging deeper into how that MCU behaves, I found out it can return
> more status codes than the "@0" for "ok".
>
> The additional codes can report a failed checksum verification and
> some "general" error for the command execution.
>
> This also explains sporadic command timeout messages, I have seen
> over time, when the controller sends an error code while we expect
> a longer reply from it.
>
> [...]
Applied, thanks!
[1/4] mfd: qnap-mcu: Calculate the checksum on the actual number of bytes received
commit: b4881070a02b017aea84592c424d5a980ed261c4
[2/4] mfd: qnap-mcu: Use EPROTO in stead of EIO on checksum errors
commit: c94fce30e190555d74e2769b5fe4a932d0ad432e
[3/4] mfd: qnap-mcu: Move checksum verification to its own function
commit: c3223f562586307b1bcb014475d0b71913972145
[4/4] mfd: qnap-mcu: Add proper error handling for command errors
commit: 56c1245d51faab70bf68cc3a5cd3925768e6375b
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2025-11-20 10:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 23:47 Heiko Stuebner
2025-11-05 23:47 ` [PATCH v2 1/4] mfd: qnap-mcu: Calculate the checksum on the actual number of bytes received Heiko Stuebner
2025-11-05 23:47 ` [PATCH v2 2/4] mfd: qnap-mcu: Use EPROTO in stead of EIO on checksum errors Heiko Stuebner
2025-11-05 23:47 ` [PATCH v2 3/4] mfd: qnap-mcu: Move checksum verification to its own function Heiko Stuebner
2025-11-05 23:47 ` [PATCH v2 4/4] mfd: qnap-mcu: Add proper error handling for command errors Heiko Stuebner
2025-11-13 16:03 ` Lee Jones
2025-11-20 10:15 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176363370523.591986.4093894713182191137.b4-ty@kernel.org \
--to=lee@kernel.org \
--cc=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®