From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0333A30AABF for ; Thu, 20 Nov 2025 10:15:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763633708; cv=none; b=bp6DDmWyJ+dXw0q+JWdX+j2PLQlkHqhsAUvKeFx7n2BJ6LtDhQj+R/tYuMsuzosx1+Wio2uJRmrrOu16M796gntdbGk1e1GJPSnWtgiyY3r3q4ErjbkVizhosqheu1s+SMWJM0sVq9Wqx3jqSxa8XA/iL++4VQjaPoEZU68Dm9Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763633708; c=relaxed/simple; bh=4HOQBDSMB9GEXG7Ok3RojUSjd96ikBiTdBdzt6VbdhA=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=fEHK9JEFZGTEsBriR4tN4Vt6rLr9NWO5ZVOB5ezdi0BmRCW6Gn6VqBtE/pqLxld2bq7pIgkYpMyAivTNZbZXM9a5Pdk4hO/pdZ6f0H/uGd6IH/A8yls1jJxvPFNk4AcGr9guGmv8Lh5/6J6jGf52X0Z6fIfF2eLW0jexEs4Jz0k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=js0qBd3u; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="js0qBd3u" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1975C116B1; Thu, 20 Nov 2025 10:15:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763633707; bh=4HOQBDSMB9GEXG7Ok3RojUSjd96ikBiTdBdzt6VbdhA=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=js0qBd3uFYrzR1Ph5vYtlr3eTXGKTaeZDMZ+upLNAIfFwKC4W/grvHSipgQ/S5m+q 4LV+h0XK9M+ygNxKovwP/CIxG16lZpd+xGTlqKSVfeLRAAfjS8M/jP8RbKxa4KU467 5MZA8tUVfENklyZ6NlVn/BXa/8+MEdtyqYerPUmeCwqmu/iiji/WjT+3VLbIcl+cX2 Inrsj4YPmvyMQarTeYpwUk1bjRHXmfbVVQejbBzAE9hVCXBATfSzx33BZqTfexuMi0 LhAQOYJIo53KJteOYsGUUDVJdpFgbDlAXIhTnZ7svD4Oy2O7y0ctW9BJehmCI2Bnnd cPnxU03kG7w0g== From: Lee Jones To: lee@kernel.org, Heiko Stuebner Cc: linux-kernel@vger.kernel.org In-Reply-To: <20251113165218.449616-1-heiko@sntech.de> References: <20251113165218.449616-1-heiko@sntech.de> Subject: Re: [PATCH v3 0/4] Improve error handling for qnap-mcu transfers Message-Id: <176363370646.591986.11942329205687467723.b4-ty@kernel.org> Date: Thu, 20 Nov 2025 10:15:06 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.15-dev-52d38 On Thu, 13 Nov 2025 17:52:14 +0100, Heiko Stuebner wrote: > Digging deeper into how that MCU behaves, I found out it can return > more status codes than the "@0" for "ok". > > The additional codes can report a failed checksum verification and > some "general" error for the command execution. > > This also explains sporadic command timeout messages, I have seen > over time, when the controller sends an error code while we expect > a longer reply from it. > > [...] Applied, thanks! [1/4] mfd: qnap-mcu: Calculate the checksum on the actual number of bytes received commit: b4881070a02b017aea84592c424d5a980ed261c4 [2/4] mfd: qnap-mcu: Use EPROTO in stead of EIO on checksum errors commit: c94fce30e190555d74e2769b5fe4a932d0ad432e [3/4] mfd: qnap-mcu: Move checksum verification to its own function commit: c3223f562586307b1bcb014475d0b71913972145 [4/4] mfd: qnap-mcu: Add proper error handling for command errors commit: 56c1245d51faab70bf68cc3a5cd3925768e6375b -- Lee Jones [李琼斯]