From: "Rob Herring (Arm)" <robh@kernel.org>
To: Matti Vaittinen <matti.vaittinen@linux.dev>
Cc: Pavel Machek <pavel@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Linus Walleij <linus.walleij@linaro.org>,
devicetree@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Sebastian Reichel <sre@kernel.org>,
Mark Brown <broonie@kernel.org>,
linux-gpio@vger.kernel.org,
Andreas Kemnade <andreas@kemnade.info>,
Michael Turquette <mturquette@baylibre.com>,
linux-pm@vger.kernel.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-kernel@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>,
Matti Vaittinen <mazziesaccount@gmail.com>,
linux-clk@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Lee Jones <lee@kernel.org>,
linux-rtc@vger.kernel.org, linux-leds@vger.kernel.org,
Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Bartosz Golaszewski <brgl@bgdev.pl>
Subject: Re: [PATCH v5 04/16] dt-bindings: battery: Voltage drop properties
Date: Thu, 20 Nov 2025 10:11:19 -0600 [thread overview]
Message-ID: <176365507949.1467967.14779548559679744817.robh@kernel.org> (raw)
In-Reply-To: <93768cba6688714756fca49cc57d46a111885863.1763625920.git.mazziesaccount@gmail.com>
On Thu, 20 Nov 2025 10:20:24 +0200, Matti Vaittinen wrote:
> From: Matti Vaittinen <mazziesaccount@gmail.com>
>
> ROHM has developed a so called "zero-correction" -algorithm to improve
> the fuel-gauging accuracy close to the point where battery is depleted.
> This relies on battery specific "VDR" (voltage drop rate) tables, which
> are measured from the battery, and which describe the voltage drop rate.
> More thorough explanation about the "zero correction" and "VDR"
> parameters is here:
> https://lore.kernel.org/all/676253b9-ff69-7891-1f26-a8b5bb5a421b@fi.rohmeurope.com/
>
> Document the VDR zero-correction specific battery properties used by the
> BD71815, BD71828, BD72720 and some other ROHM chargers. (Note, charger
> drivers aren't upstream yet).
>
> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
>
> ---
>
> Revision history:
> v4 => v5:
> - Move volt-drop parameters from rohm,vdr-battry,yaml to the
> battery.yaml
> - drop rohm, -prefix from volt-drop-* properties
> - Drop the rohm,vdr-battry,yaml
> - Add comment clarifying what the rohm,volt-drop-* properties are for
> because this may no longer be obvious as they were moved to common
> battery.yaml
> - Drop Linus Walleij's rb-tag because the concept was changed
>
> v3 => v4:
> - No changes
>
> v2 => v3:
> - Constrain VDR threshold voltage to 48V
> - Use standard '-bp' -suffix for the rohm,volt-drop-soc
>
> RFCv1 => v2:
> - Add units to rohm,volt-drop-soc (tenths of %)
> - Give real temperatures matching the VDR tables, instead of vague
> 'high', 'normal', 'low', 'very low'. (Add table of temperatures and
> use number matching the right temperature index in the VDR table name).
> - Fix typoed 'algorithm' in commit message.
>
> The parameters are describing the battery voltage drop rates - so they
> are properties of the battery, not the charger. Thus they do not belong
> in the charger node.
>
> The right place for them is the battery node, which is described by the
> generic "battery.yaml". There were some discussion whether these
> properties should be in their own file, or if they should be added to
> battery.yaml. Discussion can be found from:
> https://lore.kernel.org/all/52b99bf7-bfea-4cee-aa57-4c13e87eaa0d@gmail.com/
> This patch implements the volt-drop properties as generic (not vemdor
> specific) properties in the battery.yaml. It's worth noting that these
> properties are:
>
> - Meaningful only for those charger drivers which have the VDR
> algorithm implemented. (And even though the algorithm is not charger
> specific, AFAICS, it is currently only used by some ROHM PMIC
> drivers).
> - Technique of measuring the VDR tables for a battery is not widely
> known. AFAICS, only folks at ROHM are measuring those for some
> customer products. We do have those tables available for some of the
> products, like Kobo e-readers though.
> ---
> .../bindings/power/supply/battery.yaml | 22 +++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
next prev parent reply other threads:[~2025-11-20 16:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 8:19 [PATCH v5 00/16] Support ROHM BD72720 PMIC Matti Vaittinen
2025-11-20 8:19 ` [PATCH v5 01/16] dt-bindings: regulator: ROHM BD72720 Matti Vaittinen
2025-11-20 9:57 ` Rob Herring (Arm)
2025-11-20 8:19 ` [PATCH v5 02/16] dt-bindings: battery: Clarify trickle-charge Matti Vaittinen
2025-11-20 8:20 ` [PATCH v5 03/16] dt-bindings: battery: Add trickle-charge upper limit Matti Vaittinen
2025-11-20 8:20 ` [PATCH v5 04/16] dt-bindings: battery: Voltage drop properties Matti Vaittinen
2025-11-20 16:11 ` Rob Herring (Arm) [this message]
2025-11-20 8:20 ` [PATCH v5 05/16] dt-bindings: mfd: ROHM BD72720 Matti Vaittinen
2025-11-20 8:20 ` [PATCH v5 06/16] dt-bindings: leds: bd72720: Add BD72720 Matti Vaittinen
2025-11-20 8:21 ` [PATCH v5 07/16] mfd: rohm-bd71828: Use regmap_reg_range() Matti Vaittinen
2025-11-26 14:33 ` Lee Jones
2025-11-20 8:22 ` [PATCH v5 08/16] mfd: bd71828: Support ROHM BD72720 Matti Vaittinen
2025-11-26 14:28 ` Lee Jones
2025-11-27 7:46 ` Matti Vaittinen
2025-11-20 8:23 ` [PATCH v5 09/16] regulator: bd71828: rename IC specific entities Matti Vaittinen
2025-11-20 8:23 ` [PATCH v5 10/16] regulator: bd71828: Support ROHM BD72720 Matti Vaittinen
2025-11-20 8:23 ` [PATCH v5 11/16] gpio: Support ROHM BD72720 gpios Matti Vaittinen
2025-11-20 8:23 ` [PATCH v5 12/16] clk: clk-bd718x7: Support BD72720 clk gate Matti Vaittinen
2025-11-20 8:23 ` [PATCH v5 13/16] rtc: bd70528: Support BD72720 rtc Matti Vaittinen
2025-11-20 8:24 ` [PATCH v5 14/16] power: supply: bd71828: Support wider register addresses Matti Vaittinen
2025-11-20 8:24 ` [PATCH v5 15/16] power: supply: bd71828-power: Support ROHM BD72720 Matti Vaittinen
2025-11-20 8:24 ` [PATCH v5 16/16] MAINTAINERS: Add ROHM BD72720 PMIC Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176365507949.1467967.14779548559679744817.robh@kernel.org \
--to=robh@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=andreas@kemnade.info \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=matti.vaittinen@linux.dev \
--cc=mazziesaccount@gmail.com \
--cc=mturquette@baylibre.com \
--cc=pavel@kernel.org \
--cc=sboyd@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®