mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	 Arnaldo Carvalho de Melo <acme@kernel.org>,
	 Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	 Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	 James Clark <james.clark@linaro.org>,
	German Gomez <german.gomez@arm.com>,
	 Ravi Bangoria <ravi.bangoria@amd.com>,
	 Christophe Leroy <christophe.leroy@csgroup.eu>,
	 Chun-Tse Shao <ctshao@google.com>,
	linux-perf-users@vger.kernel.org,  linux-kernel@vger.kernel.org,
	kernel test robot <oliver.sang@intel.com>,
	 Ian Rogers <irogers@google.com>
Subject: Re: [PATCH v1 1/2] perf maps: Avoid RC_CHK use after free
Date: Thu, 20 Nov 2025 11:02:27 -0800	[thread overview]
Message-ID: <176366534773.3323482.11545683532910788298.b4-ty@kernel.org> (raw)
In-Reply-To: <20251119050555.2017758-1-irogers@google.com>

On Tue, 18 Nov 2025 21:05:54 -0800, Ian Rogers wrote:
> The case of __maps__fixup_overlap_and_insert where the "new" maps
> covers existing mappings can create a use-after-free with reference
> count checking enabled. The issue is that "pos" holds a map pointer
> from maps_by_address that is put from maps_by_address but then used to
> look for a map in maps_by_name (the compared map is now a
> use-after-free). The issue stems from using maps__remove which redoes
> some of the searches already done by __maps__fixup_overlap_and_insert,
> so optimize the code (by avoiding repeated searches) and avoid the
> use-after-free by inlining the appropriate removal code.
> 
> [...]
Applied to perf-tools-next, thanks!

Best regards,
Namhyung



      parent reply	other threads:[~2025-11-20 19:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-19  5:05 Ian Rogers
2025-11-19  5:05 ` [PATCH v1 2/2] perf test maps: Additional maps__fixup_overlap_and_insert tests Ian Rogers
2025-11-19 12:33   ` James Clark
2025-11-19 12:33 ` [PATCH v1 1/2] perf maps: Avoid RC_CHK use after free James Clark
2025-11-20 19:02 ` Namhyung Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176366534773.3323482.11545683532910788298.b4-ty@kernel.org \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=ctshao@google.com \
    --cc=german.gomez@arm.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=oliver.sang@intel.com \
    --cc=peterz@infradead.org \
    --cc=ravi.bangoria@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®