From: Mark Brown <broonie@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Cc: shenghao-ding@ti.com, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, lumag@kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] ASoC: codecs: wcd934x: add explicit soundwire depenency
Date: Fri, 21 Nov 2025 22:11:46 +0000 [thread overview]
Message-ID: <176376310618.101329.9975086867710479356.b4-ty@kernel.org> (raw)
In-Reply-To: <20251121143258.229138-1-srinivas.kandagatla@oss.qualcomm.com>
On Fri, 21 Nov 2025 14:32:58 +0000, Srinivas Kandagatla wrote:
> WCD934x provides register read/write interface to soundwire controller via
> slimbus. Eventhough there was no direct compile time dependency for
> this so far, however after adding common wcd functions this dependency
> became explict.
>
> We can either move the soundwire specific bits from wcd-common to wcd-sdw.c or
> something on those lines or explicity add this dependency in Kconfig.
> Moving this wcd-sdw can fix reported compile issue but it does not make
> sense to select this codec without soundwire configs.
> Given the fact that WCD934x is very much providing soundwire functionality
> it is better to specify the soundwire dependency explicity in Kconfig
> which should also fix the below compile time error with combination
> of wcd934x a built-in and soundwire a module and also allow this codec
> selection only when soundwire is available.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: codecs: wcd934x: add explicit soundwire depenency
commit: a3d8f733d453ed4d4eb1f0e894eec787777465a2
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
next prev parent reply other threads:[~2025-11-21 22:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 14:32 Srinivas Kandagatla
2025-11-21 22:11 ` Mark Brown [this message]
2025-11-22 19:03 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176376310618.101329.9975086867710479356.b4-ty@kernel.org \
--to=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lumag@kernel.org \
--cc=perex@perex.cz \
--cc=shenghao-ding@ti.com \
--cc=srinivas.kandagatla@oss.qualcomm.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®