From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Qipeng Zha <qipeng.zha@intel.com>,
Dan Carpenter <dan.carpenter@linaro.org>
Cc: Hans de Goede <hansg@kernel.org>,
Darren Hart <dvhart@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] platform/x86: intel: punit_ipc: fix memory corruption
Date: Mon, 24 Nov 2025 15:40:54 +0200 [thread overview]
Message-ID: <176399165439.1782.14998465716898808944.b4-ty@linux.intel.com> (raw)
In-Reply-To: <aSCmoBipSQ_tlD-D@stanley.mountain>
On Fri, 21 Nov 2025 20:51:28 +0300, Dan Carpenter wrote:
> This passes the address of the pointer "&punit_ipcdev" when the intent
> was to pass the pointer itself "punit_ipcdev" (without the ampersand).
> This means that the:
>
> complete(&ipcdev->cmd_complete);
>
> in intel_punit_ioc() will write to a wrong memory address corrupting it.
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.
The list of commits applied:
[1/1] platform/x86: intel: punit_ipc: fix memory corruption
commit: 9b9c0adbc3f8a524d291baccc9d0c04097fb4869
--
i.
prev parent reply other threads:[~2025-11-24 13:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 17:51 Dan Carpenter
2025-11-24 13:40 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176399165439.1782.14998465716898808944.b4-ty@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dan.carpenter@linaro.org \
--cc=dvhart@linux.intel.com \
--cc=hansg@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=qipeng.zha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®